fix #30108, mock support for callable classes

fix #30108, mock support for callable classes

R=vsm@google.com

Committed: https://github.com/dart-lang/sdk/commit/cc167f5901ec4a7231261b5e8d39a5f6632a3cd0

[Jennifer Messerly, 2017-07-14 08:08:04]

Description was changed from

==========
fix #30108, mock support for callabke classes
==========

to

==========
fix #30108, mock support for callable classes
==========

[Jennifer Messerly, 2017-07-14 08:08:04]

jmesserly@google.com changed reviewers:
+ vsm@google.com

[Jennifer Messerly, 2017-07-14 08:14:23]

Patchset #1 (id:1) has been deleted

[vsm, 2017-07-14 14:19:56]

lgtm

https://codereview.chromium.org/2975273002/diff/20001/pkg/dev_compiler/lib/sr...
File pkg/dev_compiler/lib/src/compiler/code_generator.dart (right):

https://codereview.chromium.org/2975273002/diff/20001/pkg/dev_compiler/lib/sr...
pkg/dev_compiler/lib/src/compiler/code_generator.dart:1840: //
call-implemented-by-nSM will be dispatched by dcall at runtime.
Remove or update the two lines above?

[Jennifer Messerly, 2017-07-14 18:40:20]

thanks!

https://codereview.chromium.org/2975273002/diff/20001/pkg/dev_compiler/lib/sr...
File pkg/dev_compiler/lib/src/compiler/code_generator.dart (right):

https://codereview.chromium.org/2975273002/diff/20001/pkg/dev_compiler/lib/sr...
pkg/dev_compiler/lib/src/compiler/code_generator.dart:1840: //
call-implemented-by-nSM will be dispatched by dcall at runtime.
On 2017/07/14 14:19:56, vsm wrote:
> Remove or update the two lines above?

they're still accurate but i'll try and clarify:

    // We can ignore `noSuchMethod` because:
    // * `dynamic d; d();` without a declared `call` method is handled by dcall.
    // * for `class C implements Callable { noSuchMethod(i) { ... } }` we find
    //   the `call` method on the `Callable` interface.

[Jennifer Messerly, 2017-07-14 19:42:27]

Description was changed from

==========
fix #30108, mock support for callable classes
==========

to

==========
fix #30108, mock support for callable classes

R=vsm@google.com

Committed:
https://github.com/dart-lang/sdk/commit/cc167f5901ec4a7231261b5e8d39a5f6632a3cd0
==========

[Jennifer Messerly, 2017-07-14 19:42:28]

Committed patchset #1 (id:20001) manually as
cc167f5901ec4a7231261b5e8d39a5f6632a3cd0 (presubmit successful).