Format analyzer, analysis_server, analyzer_plugin, front_end and kernel with the latest dartfmt.

Format analyzer, analysis_server, analyzer_plugin, front_end and kernel with the latest dartfmt.

...instead of mixing formatting with actual changes in many CLs.

R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/00d501290645f217883290001dc50f9fc9305ad0

[Paul Berry, 2017-07-13 22:01:36]

lgtm

[Siggi Cherem (dart-lang), 2017-07-13 22:15:45]

which one is the "latest"? 

I've been using the formatter that is submitted under tools/... because that's
the one used by PRESUBMIT.py

[scheglov, 2017-07-13 23:09:24]

On 2017/07/13 22:15:45, Siggi Cherem (dart-lang) wrote:
> which one is the "latest"? 
> 
> I've been using the formatter that is submitted under tools/... because that's
> the one used by PRESUBMIT.py

The "latest" is the one in repo, or bleeding edge
https://storage.googleapis.com/dart-archive/channels/be/raw/latest/sdk/dartsd...
here.

I think tools/ has snapshots which are updated eventually, but are not exactly
bleeding edge.

[scheglov, 2017-07-13 23:28:24]

Description was changed from

==========
Format analyzer, analysis_server, analyzer_plugin, front_end and kernel with the
latest dartfmt.

...instead of mixing formatting with actual changes in many CLs.

R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=
==========

to

==========
Format analyzer, analysis_server, analyzer_plugin, front_end and kernel with the
latest dartfmt.

...instead of mixing formatting with actual changes in many CLs.

R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/00d501290645f217883290001dc50f9fc9305ad0
==========

[scheglov, 2017-07-13 23:28:26]

Committed patchset #1 (id:1) manually as
00d501290645f217883290001dc50f9fc9305ad0 (presubmit successful).

[Siggi Cherem (dart-lang), 2017-07-13 23:39:14]

On 2017/07/13 23:28:26, scheglov wrote:
> Committed patchset #1 (id:1) manually as
> 00d501290645f217883290001dc50f9fc9305ad0 (presubmit successful).

I think that then we should default to use the one under tools though. Otherwise
I'm afraid the presubmit will warn us that we are using a formatter that is too
new.

Do you agree?

[ahe, 2017-07-14 08:52:05]

On 2017/07/13 23:39:14, Siggi Cherem (dart-lang) wrote:
> On 2017/07/13 23:28:26, scheglov wrote:
> > Committed patchset #1 (id:1) manually as
> > 00d501290645f217883290001dc50f9fc9305ad0 (presubmit successful).
> 
> I think that then we should default to use the one under tools though.
Otherwise
> I'm afraid the presubmit will warn us that we are using a formatter that is
too
> new.
> 
> Do you agree?

I'd rather be using the version in the repo.

I don't understand why we have a version in tools. Not eating our own dogfood is
the fastest way to break stuff we didn't think about.

If someone needs to upload a CL where dartfmt is broken they can always use
--bypass-hooks. This is a very different situation from test.dart, which if
broken can prevent you from making progress by preventing you from testing your
new fancy way of compiling closures, etc.

Note: we'll never have negative compile times without new fancy ways of
compiling closures ;-)

[Siggi Cherem (dart-lang), 2017-07-14 14:57:03]

On 2017/07/14 08:52:05, ahe wrote:
> On 2017/07/13 23:39:14, Siggi Cherem (dart-lang) wrote:
> > On 2017/07/13 23:28:26, scheglov wrote:
> > > Committed patchset #1 (id:1) manually as
> > > 00d501290645f217883290001dc50f9fc9305ad0 (presubmit successful).
> > 
> > I think that then we should default to use the one under tools though.
> Otherwise
> > I'm afraid the presubmit will warn us that we are using a formatter that is
> too
> > new.
> > 
> > Do you agree?
> 
> I'd rather be using the version in the repo.
> 
> I don't understand why we have a version in tools. Not eating our own dogfood
is
> the fastest way to break stuff we didn't think about.
> 
> If someone needs to upload a CL where dartfmt is broken they can always use
> --bypass-hooks. This is a very different situation from test.dart, which if
> broken can prevent you from making progress by preventing you from testing
your
> new fancy way of compiling closures, etc.
> 
> Note: we'll never have negative compile times without new fancy ways of
> compiling closures ;-)

OK - I'm not opposed to that, but I believe that change should be done at the
PRESUBMIT level, not on our own code alone. In particular, I already noticed
that I'm getting warnings because of the version mismatch (the PRESUBMIT says
that a couple files have "formatting errors") :(

I filed https://github.com/dart-lang/sdk/issues/30164 to see whether that change
in PRESUBMIT is possible.