Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2975193002: Fix bug in test's /none version. Update status files. (Closed)

Created:
3 years, 5 months ago by Lasse Reichstein Nielsen
Modified:
3 years, 3 months ago
Reviewers:
eernst
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix bug in test's /none version. Update status files. R=eernst@google.com Committed: https://github.com/dart-lang/sdk/commit/8e21707a4725df983d1afe6c92e602efb389314c

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -22 lines) Patch
M sdk/lib/convert/base64.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/assertion_initializer_const_function_test.dart View 1 2 chunks +5 lines, -5 lines 0 comments Download
M tests/language/language.status View 1 2 chunks +0 lines, -11 lines 0 comments Download
M tests/language/language_dart2js.status View 2 chunks +1 line, -4 lines 0 comments Download
M tests/language/language_kernel.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Lasse Reichstein Nielsen
3 years, 5 months ago (2017-07-13 14:57:33 UTC) #2
eernst
LGTM https://codereview.chromium.org/2975193002/diff/1/tests/language/assertion_initializer_const_function_test.dart File tests/language/assertion_initializer_const_function_test.dart (right): https://codereview.chromium.org/2975193002/diff/1/tests/language/assertion_initializer_const_function_test.dart#newcode25 tests/language/assertion_initializer_const_function_test.dart:25: Expect.throws(() => new C.bc01(1, 2), (e) => e ...
3 years, 5 months ago (2017-07-14 08:57:39 UTC) #3
Lasse Reichstein Nielsen
Committed patchset #2 (id:20001) manually as 8e21707a4725df983d1afe6c92e602efb389314c (presubmit successful).
3 years, 5 months ago (2017-07-14 12:04:15 UTC) #5
Lasse Reichstein Nielsen
3 years, 3 months ago (2017-09-06 08:18:33 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/2975193002/diff/1/tests/language/assertion_in...
File tests/language/assertion_initializer_const_function_test.dart (right):

https://codereview.chromium.org/2975193002/diff/1/tests/language/assertion_in...
tests/language/assertion_initializer_const_function_test.dart:25:
Expect.throws(() => new C.bc01(1, 2), (e) => e is AssertionError); //# 01:
continued
Good point, fixed.

Powered by Google App Engine
This is Rietveld 408576698