Introduce statement continuations following the specification

Introduce statement continuations following the specification

The next statement to be executed is captured by a statement
continuation.


BUG=
R=dmitryas@google.com

Committed: https://github.com/dart-lang/sdk/commit/1288ece5c8e4db75b8a76fa270b6de2953fb29b9

[zhivkag, 2017-07-13 11:09:51]

zhivkag@google.com changed reviewers:
+ dmitryas@google.com, kmillikin@google.com

[zhivkag, 2017-07-13 11:09:52]

Hi, 

This change introduces statement continuations to capture the next statement to
be executed in the interpreter, as in the semantics spec.

I split the support for instance creation in different CLs and marked the tests
accordingly.

Thanks!

[Dmitry Stefantsov, 2017-07-18 10:39:52]

LGTM if you respond to some questions and remarks.

https://codereview.chromium.org/2975173002/diff/1/pkg/kernel/lib/interpreter/...
File pkg/kernel/lib/interpreter/interpreter.dart (right):

https://codereview.chromium.org/2975173002/diff/1/pkg/kernel/lib/interpreter/...
pkg/kernel/lib/interpreter/interpreter.dart:249: // TODO: Add component for
exception support
Probably, the above comment should end with a full-stop.

https://codereview.chromium.org/2975173002/diff/1/pkg/kernel/lib/interpreter/...
pkg/kernel/lib/interpreter/interpreter.dart:322: /// Configuration for
evaluating a [List<InterpreterExpression>].
I think that square brackets only work on identifiers; they are turned into
hyperlinks by documenting tools.  I guess program fragments should be enclosed
in backticks.

https://codereview.chromium.org/2975173002/diff/1/pkg/kernel/lib/interpreter/...
pkg/kernel/lib/interpreter/interpreter.dart:367: /// [List<InterpreterValue>].
Same as above.  Square brackets should probably be replaced with backticks.

https://codereview.chromium.org/2975173002/diff/1/pkg/kernel/lib/interpreter/...
pkg/kernel/lib/interpreter/interpreter.dart:446: /// suffixed with "SK"
Probably, there should be a full-stop at the end.

https://codereview.chromium.org/2975173002/diff/1/pkg/kernel/lib/interpreter/...
pkg/kernel/lib/interpreter/interpreter.dart:616: class ExpressionSK extends
ExpressionContinuation {
Why is it marked "SK" now instead of "EK"?

https://codereview.chromium.org/2975173002/diff/1/pkg/kernel/lib/interpreter/...
pkg/kernel/lib/interpreter/interpreter.dart:879: /// Execution of a statement
completes in one of the following ways:
I think items of this list should be made sentences, i.e. they should start with
a capital letter and end with a full-stop.

https://codereview.chromium.org/2975173002/diff/1/pkg/kernel/lib/interpreter/...
pkg/kernel/lib/interpreter/interpreter.dart:894: ;
Why do we need this semicolon?

[zhivkag, 2017-07-18 11:01:10]

Thanks for the review Dima! 

Your remarks have been applied.

https://codereview.chromium.org/2975173002/diff/1/pkg/kernel/lib/interpreter/...
File pkg/kernel/lib/interpreter/interpreter.dart (right):

https://codereview.chromium.org/2975173002/diff/1/pkg/kernel/lib/interpreter/...
pkg/kernel/lib/interpreter/interpreter.dart:249: // TODO: Add component for
exception support
On 2017/07/18 10:39:52, Dmitry Stefantsov wrote:
> Probably, the above comment should end with a full-stop.

Done.

https://codereview.chromium.org/2975173002/diff/1/pkg/kernel/lib/interpreter/...
pkg/kernel/lib/interpreter/interpreter.dart:322: /// Configuration for
evaluating a [List<InterpreterExpression>].
On 2017/07/18 10:39:52, Dmitry Stefantsov wrote:
> I think that square brackets only work on identifiers; they are turned into
> hyperlinks by documenting tools.  I guess program fragments should be enclosed
> in backticks.

Done.

https://codereview.chromium.org/2975173002/diff/1/pkg/kernel/lib/interpreter/...
pkg/kernel/lib/interpreter/interpreter.dart:367: /// [List<InterpreterValue>].
On 2017/07/18 10:39:52, Dmitry Stefantsov wrote:
> Same as above.  Square brackets should probably be replaced with backticks.

Done.

https://codereview.chromium.org/2975173002/diff/1/pkg/kernel/lib/interpreter/...
pkg/kernel/lib/interpreter/interpreter.dart:446: /// suffixed with "SK"
On 2017/07/18 10:39:52, Dmitry Stefantsov wrote:
> Probably, there should be a full-stop at the end.

Done.

https://codereview.chromium.org/2975173002/diff/1/pkg/kernel/lib/interpreter/...
pkg/kernel/lib/interpreter/interpreter.dart:616: class ExpressionSK extends
ExpressionContinuation {
On 2017/07/18 10:39:52, Dmitry Stefantsov wrote:
> Why is it marked "SK" now instead of "EK"?

Indeed, this should be marked with "EK". Done.

https://codereview.chromium.org/2975173002/diff/1/pkg/kernel/lib/interpreter/...
pkg/kernel/lib/interpreter/interpreter.dart:879: /// Execution of a statement
completes in one of the following ways:
On 2017/07/18 10:39:52, Dmitry Stefantsov wrote:
> I think items of this list should be made sentences, i.e. they should start
with
> a capital letter and end with a full-stop.

Done.

https://codereview.chromium.org/2975173002/diff/1/pkg/kernel/lib/interpreter/...
pkg/kernel/lib/interpreter/interpreter.dart:894: ;
On 2017/07/18 10:39:52, Dmitry Stefantsov wrote:
> Why do we need this semicolon?

Done.

[zhivkag, 2017-07-18 11:04:02]

Description was changed from

==========
Introduce statement continuations following the specification

The next statement to be executed is captured by a statement
continuation.


BUG=
==========

to

==========
Introduce statement continuations following the specification

The next statement to be executed is captured by a statement
continuation.


BUG=
R=dmitryas@google.com

Committed:
https://github.com/dart-lang/sdk/commit/1288ece5c8e4db75b8a76fa270b6de2953fb29b9
==========

[zhivkag, 2017-07-18 11:04:03]

Committed patchset #2 (id:20001) manually as
1288ece5c8e4db75b8a76fa270b6de2953fb29b9 (presubmit successful).