Issue 297513009: Clean up device_{motion,orientation}_event_pump unittests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 297513009: Clean up device_{motion,orientation}_event_pump unittests. (Closed)

Created:
6 years, 7 months ago by timvolodine

Modified:
6 years, 7 months ago

Reviewers:
Michael van Ouwerkerk

CC:
chromium-reviews, riju_, darin-cc_chromium.org, jam, timvolodine, Michael van Ouwerkerk

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Clean up device_{motion,orientation}_event_pump unittests. Clean up and prettify the unittests in content/renderer/device_sensors/ to conform with preferred coding practice, i.e. private members, DISALLOW_COPY_AND_ASSIGN.. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272202

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+92 lines, -59 lines)			Patch
	M	content/renderer/device_sensors/device_motion_event_pump_unittest.cc	View		5 chunks	+37 lines, -21 lines	0 comments	Download
	M	content/renderer/device_sensors/device_orientation_event_pump_unittest.cc	View		8 chunks	+55 lines, -38 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timvolodine@chromium.org/297513009/1

6 years, 7 months ago (2014-05-22 13:47:25 UTC) #4

Message was sent while issue was closed.

Change committed as 272202

Expand Messages | Collapse Messages