Implement Mirror object for Symbols.

Implement Mirror object for Symbols.

R=rossberg@chromium.org, yurys@chromium.org
BUG=v8:3290
LOG=Y

Committed: https://code.google.com/p/v8/source/detail?r=21414

[yurys, 2014-05-21 14:18:44]

lgtm

[rossberg, 2014-05-21 14:35:52]

https://codereview.chromium.org/297513006/diff/1/src/mirror-debugger.js
File src/mirror-debugger.js (right):

https://codereview.chromium.org/297513006/diff/1/src/mirror-debugger.js#newco...
src/mirror-debugger.js:603: SymbolMirror.prototype.name = function() {
Let's call it description -- that's the term the spec uses.

https://codereview.chromium.org/297513006/diff/1/src/mirror-debugger.js#newco...
src/mirror-debugger.js:609: return 'Symbol "' + this.name() + '"';
I'd put parens around the string, so it looks like the constructor call.

https://codereview.chromium.org/297513006/diff/1/src/mirror-debugger.js#newco...
src/mirror-debugger.js:2358: o.value = mirror.name();
Should this have been .name on the LHS?

[Yang, 2014-05-21 14:58:23]

On 2014/05/21 14:35:52, rossberg wrote:
> https://codereview.chromium.org/297513006/diff/1/src/mirror-debugger.js
> File src/mirror-debugger.js (right):
> 
>
https://codereview.chromium.org/297513006/diff/1/src/mirror-debugger.js#newco...
> src/mirror-debugger.js:603: SymbolMirror.prototype.name = function() {
> Let's call it description -- that's the term the spec uses.

Changed to description

> 
>
https://codereview.chromium.org/297513006/diff/1/src/mirror-debugger.js#newco...
> src/mirror-debugger.js:609: return 'Symbol "' + this.name() + '"';
> I'd put parens around the string, so it looks like the constructor call.

Changed to simply use SymbolToString

> 
>
https://codereview.chromium.org/297513006/diff/1/src/mirror-debugger.js#newco...
> src/mirror-debugger.js:2358: o.value = mirror.name();
> Should this have been .name on the LHS?

Changed to .description

[rossberg, 2014-05-21 15:00:15]

lgtm

[Yang, 2014-05-21 15:13:57]

Committed patchset #3 manually as r21414 (presubmit successful).