Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2975053002: Encapsulate use of ast.Node in type_graph_nodes (Closed)

Created:
3 years, 5 months ago by Johnni Winther
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Encapsulate use of ast.Node in type_graph_nodes - remove use of ast.Send R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/2e21637f86c89646f91451ee3d425737a8fde3eb

Patch Set 1 #

Total comments: 4

Patch Set 2 : Updated cf. comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -52 lines) Patch
M pkg/compiler/lib/src/inferrer/builder.dart View 4 chunks +5 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/closure_tracer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/inferrer_engine.dart View 4 chunks +5 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/list_tracer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/map_tracer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_dump.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_nodes.dart View 1 18 chunks +39 lines, -35 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_system.dart View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 5 months ago (2017-07-12 10:25:00 UTC) #2
Siggi Cherem (dart-lang)
nice! lgtm https://codereview.chromium.org/2975053002/diff/1/pkg/compiler/lib/src/inferrer/type_graph_nodes.dart File pkg/compiler/lib/src/inferrer/type_graph_nodes.dart (right): https://codereview.chromium.org/2975053002/diff/1/pkg/compiler/lib/src/inferrer/type_graph_nodes.dart#newcode761 pkg/compiler/lib/src/inferrer/type_graph_nodes.dart:761: // [_call] instance methods. undo this one ...
3 years, 5 months ago (2017-07-12 19:11:49 UTC) #3
Johnni Winther
Committed patchset #2 (id:20001) manually as 2e21637f86c89646f91451ee3d425737a8fde3eb (presubmit successful).
3 years, 5 months ago (2017-07-13 09:28:58 UTC) #5
Johnni Winther
3 years, 5 months ago (2017-07-13 09:29:34 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/2975053002/diff/1/pkg/compiler/lib/src/inferr...
File pkg/compiler/lib/src/inferrer/type_graph_nodes.dart (right):

https://codereview.chromium.org/2975053002/diff/1/pkg/compiler/lib/src/inferr...
pkg/compiler/lib/src/inferrer/type_graph_nodes.dart:761: // [_call] instance
methods.
On 2017/07/12 19:11:48, Siggi Cherem (dart-lang) wrote:
> undo this one :)

Done.

https://codereview.chromium.org/2975053002/diff/1/pkg/compiler/lib/src/inferr...
pkg/compiler/lib/src/inferrer/type_graph_nodes.dart:1217: // Conditional sends
(e.g. `a?.b`) may be null if the receiver is null.
On 2017/07/12 19:11:48, Siggi Cherem (dart-lang) wrote:
> since we no longer use "Send", maybe update the comment too?
> 
> e.g. sends => call sites
> 

Done.

Powered by Google App Engine
This is Rietveld 408576698