Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: components/tracing/common/graphics_memory_dump_provider_android_unittest.cc

Issue 2975033002: [tracing] Optimize TracedValue::AppendAsTraceFormat(). (Closed)
Patch Set: Fix GraphicsMemoryDumpProviderTest Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/base/filter_operations_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/tracing/common/graphics_memory_dump_provider_android_unittest.cc
diff --git a/components/tracing/common/graphics_memory_dump_provider_android_unittest.cc b/components/tracing/common/graphics_memory_dump_provider_android_unittest.cc
index 5416b2ced24e21c16c40e85ad2b79de39d776a4e..ab003526dccff6d8892dbb84177b2f70e042b23e 100644
--- a/components/tracing/common/graphics_memory_dump_provider_android_unittest.cc
+++ b/components/tracing/common/graphics_memory_dump_provider_android_unittest.cc
@@ -25,10 +25,10 @@ TEST(GraphicsMemoryDumpProviderTest, ParseResponse) {
std::string json;
mad->attributes_for_testing()->AppendAsTraceFormat(&json);
ASSERT_EQ(
- "{\"memtrack_pss\":{\"type\":\"scalar\",\"units\":\"bytes\",\"value\":"
- "\"22\"},"
- "\"memtrack_total\":{\"type\":\"scalar\",\"units\":\"bytes\",\"value\":"
- "\"c\"}}",
+ "{\"memtrack_total\":{\"type\":\"scalar\",\"units\":\"bytes\",\"value\":"
+ "\"c\"},"
+ "\"memtrack_pss\":{\"type\":\"scalar\",\"units\":\"bytes\",\"value\":"
+ "\"22\"}}",
json);
// Check the "gl" row.
@@ -37,10 +37,10 @@ TEST(GraphicsMemoryDumpProviderTest, ParseResponse) {
json = "";
mad->attributes_for_testing()->AppendAsTraceFormat(&json);
ASSERT_EQ(
- "{\"memtrack_pss\":{\"type\":\"scalar\",\"units\":\"bytes\",\"value\":"
- "\"4e\"},"
- "\"memtrack_total\":{\"type\":\"scalar\",\"units\":\"bytes\",\"value\":"
- "\"38\"}}",
+ "{\"memtrack_total\":{\"type\":\"scalar\",\"units\":\"bytes\",\"value\":"
+ "\"38\"},"
+ "\"memtrack_pss\":{\"type\":\"scalar\",\"units\":\"bytes\",\"value\":"
+ "\"4e\"}}",
json);
// Test for truncated input.
« no previous file with comments | « cc/base/filter_operations_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698