runtime/vm/intermediate_language.cc - Issue 2974953002: Revise assertions and fix bug in the implementation of shifts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language.cc

Issue 2974953002: Revise assertions and fix bug in the implementation of shifts (Closed)

Patch Set: Outdated comment corrected Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/intermediate_language.cc

diff --git a/runtime/vm/intermediate_language.cc b/runtime/vm/intermediate_language.cc

index 80cd226633c1c39b961cf0ddec2da0732d981dc2..42af3635fac3b7908daab12640f44d5259247682 100644

--- a/runtime/vm/intermediate_language.cc

+++ b/runtime/vm/intermediate_language.cc

@@ -1440,8 +1440,8 @@ bool BinarySmiOpInstr::ComputeCanDeoptimize() const {

}

-bool ShiftMintOpInstr::has_shift_count_check() const {

- return !RangeUtils::IsWithin(shift_range(), 0, kMintShiftCountLimit);

+bool ShiftMintOpInstr::IsShiftCountInRange() const {

+ return RangeUtils::IsWithin(shift_range(), 0, kMintShiftCountLimit);

}