Move modules-dependent eventtarget code out of core.

Source/web/WebKit.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 22 matching lines @@
 
 #include "RuntimeEnabledFeatures.h"
 #include "bindings/v8/V8Binding.h"
 #include "bindings/v8/V8Initializer.h"
 #include "core/Init.h"
 #include "core/dom/Microtask.h"
 #include "core/frame/Settings.h"
 #include "core/page/Page.h"
 #include "core/workers/WorkerGlobalScopeProxy.h"
 #include "gin/public/v8_platform.h"
+#include "modules/InitModules.h"
 #include "platform/LayoutTestSupport.h"
 #include "platform/Logging.h"
 #include "platform/graphics/ImageDecodingStore.h"
 #include "platform/graphics/media/MediaPlayer.h"
 #include "platform/heap/Heap.h"
 #include "platform/heap/glue/MessageLoopInterruptor.h"
 #include "platform/heap/glue/PendingGCRunner.h"
 #include "public/platform/Platform.h"
 #include "public/platform/WebPrerenderingSupport.h"
 #include "public/platform/WebThread.h"
@@ skipping 107 matching lines @@
     // currentThread will always be non-null in production, but can be null in Chromium unit tests.
     if (WebThread* currentThread = platform->currentThread()) {
         ASSERT(!s_pendingGCRunner);
         s_pendingGCRunner = new WebCore::PendingGCRunner;
         currentThread->addTaskObserver(s_pendingGCRunner);
 
         ASSERT(!s_messageLoopInterruptor);
         s_messageLoopInterruptor = new WebCore::MessageLoopInterruptor(currentThread);
         WebCore::ThreadState::current()->addInterruptor(s_messageLoopInterruptor);
     }
-    WebCore::init();
+
+    DEFINE_STATIC_LOCAL(WebCore::ModulesInitializer, initializer, ());

[eseidel, 2014/05/19 21:44:23]

So why can't we just call WebCore::init() and Modules::init() separately?  Why
do we need this class with virtual dispatch?  It feels like we just want to
split WebCore::init() into two pieces?  Or have Modules::init() register itself
with core so it can be inited when Core::init() is called?

[c.shu, 2014/05/19 21:53:03]

Thanks for the review, Eric. The problem was that the init() calls on each
component in WebCore::init() are dependent on the order. We cannot do a list of
calls on Foos::init() and then a list of Foos::initModules(), or vice versa. For
example, EventTargetNames::initModules() has to be called right after
EventTargetNames::init() but not after everything else has been initialized. We
can register EventTargetNames::initModules to core but this is similar to the
virtual function approach, right?

+    initializer.init();
 
     // There are some code paths (for example, running WebKit in the browser
     // process and calling into LocalStorage before anything else) where the
     // UTF8 string encoding tables are used on a background thread before
     // they're set up.  This is a problem because their set up routines assert
     // they're running on the main WebKitThread.  It might be possible to make
     // the initialization thread-safe, but given that so many code paths use
     // this, initializing this lazily probably doesn't buy us much.
     WTF::UTF8Encoding();
 
@@ skipping 77 matching lines @@
         channel->state = WTFLogChannelOn;
 #endif // !LOG_DISABLED
 }
 
 void resetPluginCache(bool reloadPages)
 {
     WebCore::Page::refreshPlugins(reloadPages);
 }
 
 } // namespace blink