Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 2974863002: Reland of Pass -no-canonical-prefixes to clang by default. (Closed)

Created:
3 years, 5 months ago by Dirk Pranke
Modified:
3 years, 5 months ago
Reviewers:
hans, shinyak
CC:
chromium-reviews, nodir
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Pass -no-canonical-prefixes to clang by default. (patchset #1 id:1 of https://codereview.chromium.org/2936053003/ ) Reason for revert: Trying again now that the compiler has been fixed. Original issue's description: > Revert of Pass -no-canonical-prefixes to clang by default. (patchset #3 id:40001 of https://codereview.chromium.org/2842063002/ ) > > Reason for revert: > This is possibly breaking CrOS builds, see comment #30 and the updates on crbug.com/712797. > > Original issue's description: > > Pass -no-canonical-prefixes to clang by default. > > > > When clang invokes its subtools, by default it passes a default > > path to them as an absolute path. We don't really need this to > > be absolute, and having goma stores the the command lines that > > in its cache entry keys, which means that differing absolute > > paths can cause cache misses. So, this CL tells clang to > > stop doing that. > > > > R=thakis@chromium.org, shinyak@chromium.org > > BUG=706224 > > > > Review-Url: https://codereview.chromium.org/2842063002 > > Cr-Commit-Position: refs/heads/master@{#478859} > > Committed: https://chromium.googlesource.com/chromium/src/+/0e8121522085f344b83cc86c514e4bfb7f7c5a22 > > TBR=shinyak@chromium.org,thakis@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=706224 > > Review-Url: https://codereview.chromium.org/2936053003 > Cr-Commit-Position: refs/heads/master@{#479193} > Committed: https://chromium.googlesource.com/chromium/src/+/cc66e92a5fcbb8810000303fc1d93094561479a5 R=hans@chromium.org BUG=712797

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M build/config/compiler/BUILD.gn View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Dirk Pranke
Created Reland of Pass -no-canonical-prefixes to clang by default.
3 years, 5 months ago (2017-07-11 01:02:41 UTC) #1
Dirk Pranke
3 years, 5 months ago (2017-07-11 01:03:32 UTC) #4
shinyak
lgtm
3 years, 5 months ago (2017-07-11 02:21:52 UTC) #8
Dirk Pranke
3 years, 5 months ago (2017-07-14 00:03:44 UTC) #11
Message was sent while issue was closed.
Abandoning this CL; I've posted a revised version to Gerrit:
https://chromium-review.googlesource.com/c/571440/.

Powered by Google App Engine
This is Rietveld 408576698