Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2974843002: Silence truncating_ints_test in dart2js mode (Closed)

Created:
3 years, 5 months ago by alexmarkov
Modified:
3 years, 5 months ago
Reviewers:
zra, regis, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Silence truncating_ints_test in dart2js & dartium modes Dart2js does not support --limit-ints-to-64-bits option which is required by this test. Dartium does not support VMOptions specification in the test. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/47ad7a82b3ee4d06d7491b64a449d868dfc5ac1d

Patch Set 1 #

Patch Set 2 : Exclude test for dartium/drt as it relies on VMOptions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M runtime/tests/vm/vm.status View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
alexmarkov
3 years, 5 months ago (2017-07-10 23:42:57 UTC) #2
alexmarkov
3 years, 5 months ago (2017-07-10 23:53:06 UTC) #3
siva
lgtm
3 years, 5 months ago (2017-07-11 00:11:29 UTC) #4
alexmarkov
3 years, 5 months ago (2017-07-11 00:31:10 UTC) #5
siva
lgtm
3 years, 5 months ago (2017-07-11 00:32:55 UTC) #7
alexmarkov
3 years, 5 months ago (2017-07-11 00:33:08 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
47ad7a82b3ee4d06d7491b64a449d868dfc5ac1d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698