Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2011)

Unified Diff: chrome/browser/metrics/extension_metrics.h

Issue 297483008: Refactor HashedExtensionMetrics into ExtensionsMetricsProvider. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/metrics/extension_metrics.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/extension_metrics.h
diff --git a/chrome/browser/metrics/extension_metrics.h b/chrome/browser/metrics/extension_metrics.h
deleted file mode 100644
index bf086d23e04d78689219952f66990091cdbdaa5e..0000000000000000000000000000000000000000
--- a/chrome/browser/metrics/extension_metrics.h
+++ /dev/null
@@ -1,67 +0,0 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef CHROME_BROWSER_METRICS_EXTENSION_METRICS_H_
-#define CHROME_BROWSER_METRICS_EXTENSION_METRICS_H_
-
-#include <string>
-
-#include "base/basictypes.h"
-#include "base/memory/scoped_ptr.h"
-
-class Profile;
-
-namespace extensions {
-class ExtensionSet;
-}
-
-namespace metrics {
-class SystemProfileProto;
-}
-
-// HashedExtensionMetrics groups various constants and functions used for
-// reporting extension IDs with UMA reports (after hashing the extension IDs
-// for privacy).
-class HashedExtensionMetrics {
- public:
- explicit HashedExtensionMetrics(uint64 client_id);
- virtual ~HashedExtensionMetrics();
-
- // Writes the hashed list of installed extensions into the specified
- // SystemProfileProto object.
- void WriteExtensionList(metrics::SystemProfileProto* system_profile);
-
- protected:
- // Retrieves the set of extensions installed in the current profile. The
- // default implementation should be fine, but this can be overridden for
- // testing.
- //
- // TODO(mvrable): If metrics are ever converted to being per-profile, then
- // this should be updated to return extensions installed in a specified
- // profile.
- virtual scoped_ptr<extensions::ExtensionSet> GetInstalledExtensions();
-
- // Hashes the extension extension ID using the provided client key (which
- // must be less than kExtensionListClientKeys) and to produce an output value
- // between 0 and kExtensionListBuckets-1.
- static int HashExtension(const std::string& extension_id, uint32 client_key);
-
- private:
- // Returns the profile for which extensions will be gathered. Once a
- // suitable profile has been found, future calls will continue to return the
- // same value so that reported extensions are consistent.
- Profile* GetMetricsProfile();
-
- // The key used when hashing extension identifiers, derived from client_id.
- const int client_key_;
-
- // The profile for which extensions are gathered. Once a profile is found
- // its value is cached here so that GetMetricsProfile() can return a
- // consistent value.
- Profile* cached_profile_;
-
- DISALLOW_COPY_AND_ASSIGN(HashedExtensionMetrics);
-};
-
-#endif // CHROME_BROWSER_METRICS_EXTENSION_METRICS_H_
« no previous file with comments | « no previous file | chrome/browser/metrics/extension_metrics.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698