Issue 297483007: Revert 270890 "Unload all apps / extensions immediately when del..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 297483007: Revert 270890 "Unload all apps / extensions immediately when del..." (Closed)

Created:
6 years, 7 months ago by amineer_google

Modified:
6 years, 7 months ago

Reviewers:
scheib

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, rginda+watch_chromium.org, yoshiki+watch_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/2006/src/

Visibility:
Public.

Revert 270890 "Unload all apps / extensions immediately when del..." > Unload all apps / extensions immediately when deleting a profile. > > Previously apps could remain running with references to profiles that had been deleted by users, but before the browser shut down and profiles were fully removed. Problems included E.g. opening a link in an app would open a tab in the deleted profile. > > Relanding patch: ShutdownStartupCycle failed in build [49353], this patch was speculatively reverted in r269383 [49355], but ShutdownStartupCycle failed again in [49362] after the revert had landed. > > [49353] http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%281%29/builds/49353 > [49355] http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%281%29/builds/49355 > [49362] http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%281%29/builds/49362 > > BUG=368684 > TEST=Manual testing as described on http://crbug.com/368684#c1 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269343 > > Review URL: https://codereview.chromium.org/266343002 TBR=scheib@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271836

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -87 lines)			Patch
M	chrome/browser/background/background_contents_service.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/chrome_notification_types.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/extensions/extension_service.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/extensions/extension_service.cc	View	3 chunks	+0 lines, -16 lines	0 comments	Download
M	chrome/browser/extensions/extension_service_unittest.cc	View	9 chunks	+5 lines, -35 lines	0 comments	Download
M	chrome/browser/profiles/profile_manager.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/browser.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	extensions/browser/process_manager.cc	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	extensions/common/extension.h	View	1 chunk	+5 lines, -7 lines	0 comments	Download

Total messages: 2 (0 generated)

amineer_google

6 years, 7 months ago (2014-05-21 03:18:04 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r271836 (tree was closed).