Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp

Issue 2974823003: [M60 Merge] No AX objects for comments and other irrelevant node types (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/accessibility/AXObjectImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp
diff --git a/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp b/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp
index 15c14aa20fa614c2ca42dfdf146b3c810b8b3b67..9dfc29eabe1e1c5531120d893d96e03b257f99e2 100644
--- a/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp
+++ b/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp
@@ -350,6 +350,9 @@ AXObjectImpl* AXObjectCacheImpl::GetOrCreate(Node* node) {
if (!node)
return 0;
+ if (!node->IsElementNode() && !node->IsTextNode() && !node->IsDocumentNode())
+ return 0; // Only documents, elements and text nodes get a11y objects
+
if (AXObjectImpl* obj = Get(node))
return obj;
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/accessibility/AXObjectImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698