Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2182)

Unified Diff: tools/patch_sdk.dart

Issue 2974703002: Move forward rolling FE public APIS (make bots green) (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/patch_sdk.dart
diff --git a/tools/patch_sdk.dart b/tools/patch_sdk.dart
index eaf93275d37b9df83692851d86611996e77f60d0..e5d71883eb25bbe829d9ebe9aa0330aeb95b9ddc 100644
--- a/tools/patch_sdk.dart
+++ b/tools/patch_sdk.dart
@@ -143,7 +143,9 @@ Future _main(List<String> argv) async {
var program = await kernelForProgram(
Uri.parse('dart:$vmserviceName'),
new CompilerOptions()
- ..sdkSummary = outline
+ // TODO(sigmund): investigate. This should be outline, but it breaks
+ // vm-debug tests. Issue #30111
+ ..sdkSummary = platform
..dartLibraries = <String, Uri>{
'_vmservice': dartDir.resolve('sdk/lib/vmservice/vmservice.dart'),
'vmservice_io':
@@ -151,6 +153,10 @@ Future _main(List<String> argv) async {
}
..packagesFileUri = packages);
Uri vmserviceUri = outDirUri.resolve('$vmserviceName.dill');
+ // TODO(sigmund): remove. This is a workaround because in the VM
+ // doesn't support loading vmservice if it contains external libraries
+ // (there is an assertion that only fails in debug builds). Issue #30111
+ program.libraries.forEach((l) => l.isExternal = false);
await writeProgramToFile(program, vmserviceUri);
}
« tests/compiler/dart2js/dill_loader_test.dart ('K') | « tests/standalone/standalone.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698