Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 2974703002: Move forward rolling FE public APIS (make bots green) (Closed)

Created:
3 years, 5 months ago by Siggi Cherem (dart-lang)
Modified:
3 years, 5 months ago
Reviewers:
ahe, Paul Berry
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move forward rolling FE public APIS (make bots green) There were a couple issues found in the bots: - dart2js unit tests I accidentally missed earlier. - vmservice issues only show up in the debug-vm, I was testing locally with the release vm. - a small regression in detecting invalid .packages files. I marked the test failing for now and plan to follow up on this on Monday. TBR=ahe@google.com,paulberry@google.com Committed: https://github.com/dart-lang/sdk/commit/d844dc8226aafac52531b33d1c78de6ab140432c

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M pkg/compiler/tool/generate_kernel.dart View 2 chunks +1 line, -2 lines 0 comments Download
M tests/compiler/dart2js/dill_loader_test.dart View 1 chunk +1 line, -0 lines 1 comment Download
M tests/compiler/dart2js/kernel/compiler_helper.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/standalone/standalone.status View 1 chunk +1 line, -0 lines 0 comments Download
M tools/patch_sdk.dart View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Siggi Cherem (dart-lang)
TBR https://codereview.chromium.org/2974703002/diff/1/tests/compiler/dart2js/dill_loader_test.dart File tests/compiler/dart2js/dill_loader_test.dart (right): https://codereview.chromium.org/2974703002/diff/1/tests/compiler/dart2js/dill_loader_test.dart#newcode51 tests/compiler/dart2js/dill_loader_test.dart:51: ..compileSdk = true this was not required the ...
3 years, 5 months ago (2017-07-08 04:14:52 UTC) #3
Siggi Cherem (dart-lang)
Committed patchset #1 (id:1) manually as d844dc8226aafac52531b33d1c78de6ab140432c (presubmit successful).
3 years, 5 months ago (2017-07-08 04:15:14 UTC) #5
Paul Berry
3 years, 5 months ago (2017-07-10 15:26:19 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698