Fix remaining failures from earlier CL (that switched kernel-service and dart2js

Fix remaining failures from earlier CL (that switched kernel-service and dart2js
to use the public frontend apis.)

 * As part of the refactor I made kernel-service truncate the .dill file it
   sends to the VM so it excludes the SDK code. This works in most cases, but
   caused 26 failures in debug mode. The error matches what I saw in Issue
   #30111.

 * Some Dart2js tests using --use-sdk failed to run because they tried to find
   platform.dill incorrectly. Our bots do have it available, we just have
   to make sure to resolve it based on the build configuraiton and not based on
   the SDK executable.

Committed: https://github.com/dart-lang/sdk/commit/cc567226a823d41311eb5c09cf7e894afc1fc4c6

[Siggi Cherem (dart-lang), 2017-07-08 17:25:15]

Description was changed from

==========
Fix remaining failures from earlier CL (that switched kernel-service and dart2js
to use the public frontend apis.)

 * As part of the refactor I made kernel-service truncate the .dill file it
   sends to the VM so it excludes the SDK code. This works in most cases, but
   caused 52 failures in debug mode. The error matches what I saw in Issue
   #30111.

 * Dart2js tests using --use-sdk can't run because they don't have a
   platform.dill file available. Our bots do have that available, we just have
   to make sure to resolve it based on the build configuraiton and not based on
   the SDK executable.
==========

to

==========
Fix remaining failures from earlier CL (that switched kernel-service and dart2js
to use the public frontend apis.)

 * As part of the refactor I made kernel-service truncate the .dill file it
   sends to the VM so it excludes the SDK code. This works in most cases, but
   caused 26 failures in debug mode. The error matches what I saw in Issue
   #30111.

 * Dart2js tests using --use-sdk can't run because they don't have a
   platform.dill file available. Our bots do have that available, we just have
   to make sure to resolve it based on the build configuraiton and not based on
   the SDK executable.
==========

[Siggi Cherem (dart-lang), 2017-07-08 17:25:57]

Description was changed from

==========
Fix remaining failures from earlier CL (that switched kernel-service and dart2js
to use the public frontend apis.)

 * As part of the refactor I made kernel-service truncate the .dill file it
   sends to the VM so it excludes the SDK code. This works in most cases, but
   caused 26 failures in debug mode. The error matches what I saw in Issue
   #30111.

 * Dart2js tests using --use-sdk can't run because they don't have a
   platform.dill file available. Our bots do have that available, we just have
   to make sure to resolve it based on the build configuraiton and not based on
   the SDK executable.
==========

to

==========
Fix remaining failures from earlier CL (that switched kernel-service and dart2js
to use the public frontend apis.)

 * As part of the refactor I made kernel-service truncate the .dill file it
   sends to the VM so it excludes the SDK code. This works in most cases, but
   caused 26 failures in debug mode. The error matches what I saw in Issue
   #30111.

 * Some Dart2js tests using --use-sdk failed to run because they tried to find
   platform.dill incorrectly. Our bots do have it available, we just have
   to make sure to resolve it based on the build configuraiton and not based on
   the SDK executable.
==========

[Siggi Cherem (dart-lang), 2017-07-08 17:26:39]

sigmund@google.com changed reviewers:
+ ahe@google.com, paulberry@google.com

[Siggi Cherem (dart-lang), 2017-07-08 17:26:40]

TBR

[Siggi Cherem (dart-lang), 2017-07-08 17:26:55]

Description was changed from

==========
Fix remaining failures from earlier CL (that switched kernel-service and dart2js
to use the public frontend apis.)

 * As part of the refactor I made kernel-service truncate the .dill file it
   sends to the VM so it excludes the SDK code. This works in most cases, but
   caused 26 failures in debug mode. The error matches what I saw in Issue
   #30111.

 * Some Dart2js tests using --use-sdk failed to run because they tried to find
   platform.dill incorrectly. Our bots do have it available, we just have
   to make sure to resolve it based on the build configuraiton and not based on
   the SDK executable.
==========

to

==========
Fix remaining failures from earlier CL (that switched kernel-service and dart2js
to use the public frontend apis.)

 * As part of the refactor I made kernel-service truncate the .dill file it
   sends to the VM so it excludes the SDK code. This works in most cases, but
   caused 26 failures in debug mode. The error matches what I saw in Issue
   #30111.

 * Some Dart2js tests using --use-sdk failed to run because they tried to find
   platform.dill incorrectly. Our bots do have it available, we just have
   to make sure to resolve it based on the build configuraiton and not based on
   the SDK executable.

Committed:
https://github.com/dart-lang/sdk/commit/cc567226a823d41311eb5c09cf7e894afc1fc4c6
==========

[Siggi Cherem (dart-lang), 2017-07-08 17:26:56]

Committed patchset #1 (id:1) manually as
cc567226a823d41311eb5c09cf7e894afc1fc4c6 (presubmit successful).

[Paul Berry, 2017-07-10 15:24:50]

lgtm