Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2974673002: Revert "Fix closure conversion in field and local initializers." (Closed)

Created:
3 years, 5 months ago by sjindel
Modified:
3 years, 5 months ago
Reviewers:
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Fix closure conversion in field and local initializers." This reverts commit a49dcb6bb15e390731685869305d7e7eca5df7a8. Committed: https://github.com/dart-lang/sdk/commit/a7d1837d3d757a5cd1ba65a22a8e387bd956ea0b Committed: https://github.com/dart-lang/sdk/commit/4df146dd9a465d63344330bf3e45524b927c92ec

Patch Set 1 #

Patch Set 2 : Revert "Revert "Fix closure conversion in field and local initializers."" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -38 lines) Patch
M pkg/kernel/lib/transformations/closure/rewriter.dart View 1 2 chunks +7 lines, -10 lines 0 comments Download
M pkg/kernel/test/closures_initializers/closures_initializers.status View 1 1 chunk +0 lines, -2 lines 0 comments Download
A pkg/kernel/testcases/closures_initializers/initializers.dart View 1 1 chunk +35 lines, -0 lines 0 comments Download
A pkg/kernel/testcases/closures_initializers/initializers.dart.expect View 1 1 chunk +35 lines, -0 lines 0 comments Download
D pkg/kernel/testcases/closures_initializers/local_initializers.dart View 1 1 chunk +0 lines, -23 lines 0 comments Download
M pkg/kernel/testcases/closures_initializers/local_initializers.dart.expect View 1 1 chunk +15 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
sjindel
Committed patchset #1 (id:1) manually as a7d1837d3d757a5cd1ba65a22a8e387bd956ea0b (presubmit successful).
3 years, 5 months ago (2017-07-07 16:42:57 UTC) #2
sjindel
3 years, 5 months ago (2017-07-10 08:12:51 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4df146dd9a465d63344330bf3e45524b927c92ec (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698