pkg/compiler/lib/src/kernel/kernel_strategy.dart - Issue 2974663002: Compute source spans for IR nodes and J/K-elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/kernel/kernel_strategy.dart

Issue 2974663002: Compute source spans for IR nodes and J/K-elements (Closed)

Patch Set: Updated cf. comments Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/kernel/kernel_strategy.dart

diff --git a/pkg/compiler/lib/src/kernel/kernel_strategy.dart b/pkg/compiler/lib/src/kernel/kernel_strategy.dart

index 12896e03ab0c2f1b438fe7eb0766161e01023bde..fd95be35447dfc6e76c1427368c08acd4def5b24 100644

--- a/pkg/compiler/lib/src/kernel/kernel_strategy.dart

+++ b/pkg/compiler/lib/src/kernel/kernel_strategy.dart

@@ -143,8 +143,7 @@ class KernelFrontEndStrategy extends FrontendStrategyBase {

@override

SourceSpan spanFromSpannable(Spannable spannable, Entity currentElement) {

- // TODO(redemption): Compute source spans from kernel elements.

- return new SourceSpan(null, null, null);

+ return _elementMap.getSourceSpan(spannable, currentElement);

}