runtime/vm/intermediate_language.cc - Issue 2974633003: Option to truncate integers to 64 bits, part 1 (core VM changes)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language.cc

Issue 2974633003: Option to truncate integers to 64 bits, part 1 (core VM changes) (Closed)

Patch Set: Merged 2 flags into 1 (--limit-ints-to-64-bits) Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/intermediate_language.cc

diff --git a/runtime/vm/intermediate_language.cc b/runtime/vm/intermediate_language.cc

index 68cf40125c2256810f757cb0aa8dc01ef8ffe21c..43ce48618b512d2ff0461a004c9f56fde026b8f7 100644

--- a/runtime/vm/intermediate_language.cc

+++ b/runtime/vm/intermediate_language.cc

@@ -1818,7 +1818,7 @@ RawInteger* BinaryIntegerOpInstr::Evaluate(const Integer& left,

if (is_truncating()) {

int64_t truncated = result.AsTruncatedInt64Value();

truncated &= RepresentationMask(representation());

- result = Integer::New(truncated);

+ result = Integer::New(truncated, Heap::kOld);

ASSERT(IsRepresentable(result, representation()));

} else if (!IsRepresentable(result, representation())) {

// If this operation is not truncating it would deoptimize on overflow.