runtime/vm/intermediate_language_x64.cc - Issue 2974633003: Option to truncate integers to 64 bits, part 1 (core VM changes)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language_x64.cc

Issue 2974633003: Option to truncate integers to 64 bits, part 1 (core VM changes) (Closed)

Patch Set: Corrections in comments Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/intermediate_language_x64.cc

diff --git a/runtime/vm/intermediate_language_x64.cc b/runtime/vm/intermediate_language_x64.cc

index 6cff06c7fa2b8ab5927f66dc255cc2e656731b75..69d1586610b122c6ce0a066053bd82f6929db2bd 100644

--- a/runtime/vm/intermediate_language_x64.cc

+++ b/runtime/vm/intermediate_language_x64.cc

@@ -6072,6 +6072,8 @@ void ShiftMintOpInstr::EmitNativeCode(FlowGraphCompiler* compiler) {

ASSERT(locs()->in(1).constant().IsSmi());

const int64_t shift =

reinterpret_cast<int64_t>(locs()->in(1).constant().raw()) >> 1;

+ ASSERT(!has_shift_count_check());

+ ASSERT((0 <= shift) && (shift < 64));

switch (op_kind()) {

case Token::kSHR:

__ sarq(left, Immediate(shift));