Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2974633002: Use JsStrategy, remove KernelBackendStrategy (Closed)

Created:
3 years, 5 months ago by Johnni Winther
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org, Emily Fortuna
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Delete test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -268 lines) Patch
M pkg/compiler/lib/src/kernel/element_map_impl.dart View 4 chunks +44 lines, -123 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart View 4 chunks +1 line, -82 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_strategy.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/kernel/native_basic_data.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/kernel/no_such_method_resolver.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/js_model/model_test.dart View 1 1 chunk +0 lines, -46 lines 0 comments Download
M tests/compiler/dart2js/kernel/closed_world2_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/kernel/compiler_helper.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/kernel/impact_test.dart View 4 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Johnni Winther
3 years, 5 months ago (2017-07-07 11:33:09 UTC) #2
Emily Fortuna
lgtm. Okay, so I lied about these changes not having an impact -- this is ...
3 years, 5 months ago (2017-07-07 17:35:55 UTC) #4
Siggi Cherem (dart-lang)
lgtm - I understand that now compile_from_dill_test.dart will basically cover what you had with model_test ...
3 years, 5 months ago (2017-07-07 20:03:47 UTC) #5
Johnni Winther
On 2017/07/07 20:03:47, Siggi Cherem (dart-lang) wrote: > lgtm - I understand that now compile_from_dill_test.dart ...
3 years, 5 months ago (2017-07-10 10:09:45 UTC) #6
Johnni Winther
On 2017/07/07 17:35:55, Emily Fortuna wrote: > lgtm. > Okay, so I lied about these ...
3 years, 5 months ago (2017-07-10 10:49:11 UTC) #7
Johnni Winther
Committed patchset #2 (id:20001) manually as 3fab16c169d802a3b49a31c038b82baa8f493a4d (presubmit successful).
3 years, 5 months ago (2017-07-10 10:49:40 UTC) #9
Johnni Winther
3 years, 5 months ago (2017-07-10 12:07:57 UTC) #10
Message was sent while issue was closed. 
On 2017/07/10 10:49:11, Johnni Winther wrote:
> On 2017/07/07 17:35:55, Emily Fortuna wrote:
> > lgtm.
> > Okay, so I lied about these changes not having an impact -- this is going to
> be
> > a fun merge for me. However -- do it! It makes things simpler, which is
nice.
> 
> It merged cleanly!

Ah, _your_ merge ... fingers crossed, then!

Powered by Google App Engine
This is Rietveld 408576698