Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: net/spdy/chromium/header_coalescer.h

Issue 2974613002: Allow large response headers to buffer in HpackDecoder. (Closed)
Patch Set: naught but a nit Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/spdy/chromium/buffered_spdy_framer.cc ('k') | net/spdy/chromium/header_coalescer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2016 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_SPDY_CHROMIUM_HEADER_COALESCER_H_ 5 #ifndef NET_SPDY_CHROMIUM_HEADER_COALESCER_H_
6 #define NET_SPDY_CHROMIUM_HEADER_COALESCER_H_ 6 #define NET_SPDY_CHROMIUM_HEADER_COALESCER_H_
7 7
8 #include "net/base/net_export.h" 8 #include "net/base/net_export.h"
9 #include "net/log/net_log_with_source.h" 9 #include "net/log/net_log_with_source.h"
10 #include "net/spdy/core/spdy_header_block.h" 10 #include "net/spdy/core/spdy_header_block.h"
11 #include "net/spdy/core/spdy_headers_handler_interface.h" 11 #include "net/spdy/core/spdy_headers_handler_interface.h"
12 #include "net/spdy/platform/api/spdy_string_piece.h" 12 #include "net/spdy/platform/api/spdy_string_piece.h"
13 13
14 namespace net { 14 namespace net {
15 15
16 const size_t kMaxHeaderListSize = 256 * 1024;
17
16 class NET_EXPORT_PRIVATE HeaderCoalescer : public SpdyHeadersHandlerInterface { 18 class NET_EXPORT_PRIVATE HeaderCoalescer : public SpdyHeadersHandlerInterface {
17 public: 19 public:
18 explicit HeaderCoalescer(const NetLogWithSource& net_log); 20 explicit HeaderCoalescer(const NetLogWithSource& net_log);
19 21
20 void OnHeaderBlockStart() override {} 22 void OnHeaderBlockStart() override {}
21 23
22 void OnHeader(SpdyStringPiece key, SpdyStringPiece value) override; 24 void OnHeader(SpdyStringPiece key, SpdyStringPiece value) override;
23 25
24 void OnHeaderBlockEnd(size_t uncompressed_header_bytes, 26 void OnHeaderBlockEnd(size_t uncompressed_header_bytes,
25 size_t compressed_header_bytes) override {} 27 size_t compressed_header_bytes) override {}
(...skipping 12 matching lines...) Expand all
38 bool headers_valid_ = true; 40 bool headers_valid_ = true;
39 size_t header_list_size_ = 0; 41 size_t header_list_size_ = 0;
40 bool error_seen_ = false; 42 bool error_seen_ = false;
41 bool regular_header_seen_ = false; 43 bool regular_header_seen_ = false;
42 NetLogWithSource net_log_; 44 NetLogWithSource net_log_;
43 }; 45 };
44 46
45 } // namespace net 47 } // namespace net
46 48
47 #endif // NET_SPDY_CHROMIUM_HEADER_COALESCER_H_ 49 #endif // NET_SPDY_CHROMIUM_HEADER_COALESCER_H_
OLDNEW
« no previous file with comments | « net/spdy/chromium/buffered_spdy_framer.cc ('k') | net/spdy/chromium/header_coalescer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698