Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8527)

Unified Diff: chrome/test/data/webui/extensions/extension_item_list_test.js

Issue 2974583003: MD Extensions: Show messages for no extensions, and for no search results (Closed)
Patch Set: add md_extensions_strings.grdp=* in OWNER Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/extensions/extension_item_list_test.js
diff --git a/chrome/test/data/webui/extensions/extension_item_list_test.js b/chrome/test/data/webui/extensions/extension_item_list_test.js
index c5b09beb7ff719c468b31a8f2383ecdd50356b63..56647c7aedacf248be98fe99bf3770dd291a085a 100644
--- a/chrome/test/data/webui/extensions/extension_item_list_test.js
+++ b/chrome/test/data/webui/extensions/extension_item_list_test.js
@@ -7,12 +7,15 @@ cr.define('extension_item_list_tests', function() {
/** @enum {string} */
var TestNames = {
ItemListFiltering: 'item list filtering',
+ ItemListNoItemsMsg: 'empty item list',
+ ItemListNoSearchResultsMsg: 'empty item list filtering results',
};
function registerTests() {
suite('ExtensionItemListTest', function() {
/** @type {extensions.ItemList} */
var itemList;
+ var testVisible;
suiteSetup(function() {
return PolymerTest.importHtml('chrome://extensions/item-list.html');
@@ -22,6 +25,8 @@ cr.define('extension_item_list_tests', function() {
setup(function() {
PolymerTest.clearBody();
itemList = new extensions.ItemList();
+ testVisible = extension_test_util.testVisible.bind(null, itemList);
+
var createExt = extension_test_util.createExtensionInfo;
var items =
[createExt({name: 'Alpha', id: 'a'.repeat(32)}),
@@ -60,6 +65,24 @@ cr.define('extension_item_list_tests', function() {
itemList.filter = '';
expectEquals(3, ironList.items.length);
});
+
+ test(assert(TestNames.ItemListNoItemsMsg), function() {
+ testVisible('#no-items', false);
+ testVisible('#no-search-results', false);
+
+ itemList.items = [];
+ testVisible('#no-items', true);
+ testVisible('#no-search-results', false);
+ });
+
+ test(assert(TestNames.ItemListNoSearchResultsMsg), function() {
+ testVisible('#no-items', false);
+ testVisible('#no-search-results', false);
+
+ itemList.filter = 'non-existent name';
+ testVisible('#no-items', false);
+ testVisible('#no-search-results', true);
+ });
});
}

Powered by Google App Engine
This is Rietveld 408576698