Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Side by Side Diff: chrome/browser/ui/webui/extensions/extensions_ui.cc

Issue 2974583003: MD Extensions: Show messages for no extensions, and for no search results (Closed)
Patch Set: add md_extensions_strings.grdp=* in OWNER Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/extensions/extensions_ui.h" 5 #include "chrome/browser/ui/webui/extensions/extensions_ui.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/memory/ptr_util.h" 9 #include "base/memory/ptr_util.h"
10 #include "base/metrics/histogram_macros.h" 10 #include "base/metrics/histogram_macros.h"
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
108 108
109 source->AddLocalizedString("title", 109 source->AddLocalizedString("title",
110 IDS_MANAGE_EXTENSIONS_SETTING_WINDOWS_TITLE); 110 IDS_MANAGE_EXTENSIONS_SETTING_WINDOWS_TITLE);
111 source->AddLocalizedString("toolbarTitle", IDS_MD_EXTENSIONS_TOOLBAR_TITLE); 111 source->AddLocalizedString("toolbarTitle", IDS_MD_EXTENSIONS_TOOLBAR_TITLE);
112 source->AddLocalizedString("search", IDS_MD_EXTENSIONS_SEARCH); 112 source->AddLocalizedString("search", IDS_MD_EXTENSIONS_SEARCH);
113 // TODO(dpapad): Use a single merged string resource for "Clear search". 113 // TODO(dpapad): Use a single merged string resource for "Clear search".
114 source->AddLocalizedString("clearSearch", IDS_DOWNLOAD_CLEAR_SEARCH); 114 source->AddLocalizedString("clearSearch", IDS_DOWNLOAD_CLEAR_SEARCH);
115 source->AddLocalizedString("sidebarApps", IDS_MD_EXTENSIONS_SIDEBAR_APPS); 115 source->AddLocalizedString("sidebarApps", IDS_MD_EXTENSIONS_SIDEBAR_APPS);
116 source->AddLocalizedString("sidebarExtensions", 116 source->AddLocalizedString("sidebarExtensions",
117 IDS_MD_EXTENSIONS_SIDEBAR_EXTENSIONS); 117 IDS_MD_EXTENSIONS_SIDEBAR_EXTENSIONS);
118 source->AddLocalizedString("noExtensionsOrApps",
119 IDS_MD_EXTENSIONS_NO_INSTALLED_ITEMS);
120 source->AddLocalizedString("noSearchResults",
121 IDS_MD_EXTENSIONS_NO_SEARCH_RESULTS);
118 source->AddLocalizedString("dropToInstall", 122 source->AddLocalizedString("dropToInstall",
119 IDS_EXTENSIONS_INSTALL_DROP_TARGET); 123 IDS_EXTENSIONS_INSTALL_DROP_TARGET);
120 source->AddLocalizedString("errorsPageHeading", 124 source->AddLocalizedString("errorsPageHeading",
121 IDS_MD_EXTENSIONS_ERROR_PAGE_HEADING); 125 IDS_MD_EXTENSIONS_ERROR_PAGE_HEADING);
122 source->AddLocalizedString("getMoreExtensions", 126 source->AddLocalizedString("getMoreExtensions",
123 IDS_MD_EXTENSIONS_SIDEBAR_GET_MORE_EXTENSIONS); 127 IDS_MD_EXTENSIONS_SIDEBAR_GET_MORE_EXTENSIONS);
124 source->AddLocalizedString("keyboardShortcuts", 128 source->AddLocalizedString("keyboardShortcuts",
125 IDS_MD_EXTENSIONS_SIDEBAR_KEYBOARD_SHORTCUTS); 129 IDS_MD_EXTENSIONS_SIDEBAR_KEYBOARD_SHORTCUTS);
126 source->AddLocalizedString("itemId", IDS_MD_EXTENSIONS_ITEM_ID); 130 source->AddLocalizedString("itemId", IDS_MD_EXTENSIONS_ITEM_ID);
127 source->AddLocalizedString("itemInspectViews", 131 source->AddLocalizedString("itemInspectViews",
(...skipping 256 matching lines...) Expand 10 before | Expand all | Expand 10 after
384 ExtensionsUI::~ExtensionsUI() {} 388 ExtensionsUI::~ExtensionsUI() {}
385 389
386 // static 390 // static
387 base::RefCountedMemory* ExtensionsUI::GetFaviconResourceBytes( 391 base::RefCountedMemory* ExtensionsUI::GetFaviconResourceBytes(
388 ui::ScaleFactor scale_factor) { 392 ui::ScaleFactor scale_factor) {
389 ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance(); 393 ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
390 return rb.LoadDataResourceBytesForScale(IDR_EXTENSIONS_FAVICON, scale_factor); 394 return rb.LoadDataResourceBytesForScale(IDR_EXTENSIONS_FAVICON, scale_factor);
391 } 395 }
392 396
393 } // namespace extensions 397 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/resources/md_extensions/manager.js ('k') | chrome/test/data/webui/extensions/cr_extensions_browsertest.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698