chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java - Issue 2974573002: Refactor WebApkServiceConnectionManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java

Issue 2974573002: Refactor WebApkServiceConnectionManager. (Closed)

Patch Set: yfriedman@'s comments. Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/notifications/WebApkNotificationClient.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkServiceClient.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java

index 4c276d477a57c40d858ce79e682215b25196af13..75f9431fb5235275d801fee4e62b9a6c219cf1d9 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java

@@ -13,7 +13,6 @@ import android.os.SystemClock;

import org.chromium.base.ActivityState;

import org.chromium.base.ApiCompatibilityUtils;

import org.chromium.base.ApplicationStatus;

-import org.chromium.base.ContextUtils;

import org.chromium.base.library_loader.LibraryProcessType;

import org.chromium.base.metrics.RecordHistogram;

import org.chromium.chrome.browser.externalnav.ExternalNavigationParams;

@@ -29,7 +28,6 @@ import org.chromium.components.navigation_interception.NavigationParams;

import org.chromium.content.browser.ChildProcessCreationParams;

import org.chromium.net.NetError;

import org.chromium.net.NetworkChangeNotifier;

-import org.chromium.webapk.lib.client.WebApkServiceConnectionManager;

import org.chromium.webapk.lib.common.WebApkConstants;

import java.util.concurrent.TimeUnit;

@@ -213,8 +211,7 @@ public class WebApkActivity extends WebappActivity {

@Override

public void onStop() {

super.onStop();

- WebApkServiceConnectionManager.getInstance().disconnect(

- ContextUtils.getApplicationContext(), getWebApkPackageName());

+ WebApkServiceClient.getInstance().disconnect(getWebApkPackageName());

}

@Override