Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1796)

Unified Diff: chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkServiceConnectionManagerTest.java

Issue 2974573002: Refactor WebApkServiceConnectionManager. (Closed)
Patch Set: Call the callback on UI thread if bindService() fails. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkServiceConnectionManagerTest.java
diff --git a/chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkServiceConnectionManagerTest.java b/chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkServiceConnectionManagerTest.java
index 6f486c90c7f5fecdd5951a0698805954b48b31b9..16f0421eadb681996aca6b6c73c8fb3d34e2c6ca 100644
--- a/chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkServiceConnectionManagerTest.java
+++ b/chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkServiceConnectionManagerTest.java
@@ -8,10 +8,7 @@ import android.content.Context;
import android.content.ContextWrapper;
import android.content.Intent;
import android.content.ServiceConnection;
-
-import org.chromium.testing.local.CustomShadowAsyncTask;
-import org.chromium.testing.local.LocalRobolectricTestRunner;
-import org.chromium.webapk.lib.runtime_library.IWebApkApi;
+import android.os.IBinder;
import org.junit.Assert;
import org.junit.Before;
@@ -22,6 +19,9 @@ import org.robolectric.Shadows;
import org.robolectric.annotation.Config;
import org.robolectric.shadows.ShadowApplication;
+import org.chromium.testing.local.CustomShadowAsyncTask;
+import org.chromium.testing.local.LocalRobolectricTestRunner;
+
/**
* Unit tests for {@link org.chromium.libs.client.WebApkServiceConnectionManager}.
*/
@@ -30,6 +30,7 @@ import org.robolectric.shadows.ShadowApplication;
public class WebApkServiceConnectionManagerTest {
private static final String WEB_APK_PACKAGE = "com.webapk.package";
+ private static final String CATEGORY_WEBAPK_SERVICE_API = "android.intent.category.WEBAPK_API";
private ShadowApplication mShadowApplication;
private WebApkServiceConnectionManager mConnectionManager;
@@ -38,7 +39,7 @@ public class WebApkServiceConnectionManagerTest {
public boolean mGotResult = false;
@Override
- public void onConnected(IWebApkApi api) {
+ public void onConnected(IBinder service) {
mGotResult = true;
}
}
@@ -46,7 +47,7 @@ public class WebApkServiceConnectionManagerTest {
@Before
public void setUp() {
mShadowApplication = Shadows.shadowOf(RuntimeEnvironment.application);
- mConnectionManager = new WebApkServiceConnectionManager();
+ mConnectionManager = new WebApkServiceConnectionManager(CATEGORY_WEBAPK_SERVICE_API);
}
/**

Powered by Google App Engine
This is Rietveld 408576698