Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Issue 2974533002: Guard against an AST node with no end token (issue 30089) (Closed)

Created:
3 years, 5 months ago by Brian Wilkerson
Modified:
3 years, 5 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Guard against an AST node with no end token (issue 30089) R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/0c775ae412e6e3c01edc7ce55cd056b3cd33ccc0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M pkg/analyzer_plugin/lib/src/utilities/completion/completion_target.dart View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
I don't have a reproduction case, hence no test.
3 years, 5 months ago (2017-07-06 19:49:39 UTC) #2
scheglov
lgtm
3 years, 5 months ago (2017-07-06 19:50:46 UTC) #3
Brian Wilkerson
3 years, 5 months ago (2017-07-06 19:51:28 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0c775ae412e6e3c01edc7ce55cd056b3cd33ccc0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698