Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Unified Diff: components/cast_channel/cast_socket.h

Issue 2974523002: [cast_channel] Make CastSocketService a global leaky singleton (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cast_channel/cast_socket.h
diff --git a/components/cast_channel/cast_socket.h b/components/cast_channel/cast_socket.h
index e51d26f281efddbf17f325fce34030ce000ff04f..81b81755fdfc5da983678e7df05117477f3d4519 100644
--- a/components/cast_channel/cast_socket.h
+++ b/components/cast_channel/cast_socket.h
@@ -129,6 +129,9 @@ class CastSocket {
// Registers |observer| with the socket to receive messages and error events.
virtual void AddObserver(Observer* observer) = 0;
+
+ // Unregisters |observer|
mark a. foltz 2017/07/10 20:43:05 Nit: Add period at end.
zhaobin 2017/07/12 21:58:08 Done.
+ virtual void RemoveObserver(Observer* observer) = 0;
};
// This class implements a channel between Chrome and a Cast device using a TCP
@@ -181,6 +184,7 @@ class CastSocketImpl : public CastSocket {
bool keep_alive() const override;
bool audio_only() const override;
void AddObserver(Observer* observer) override;
+ void RemoveObserver(Observer* observer) override;
protected:
// CastTransport::Delegate methods for receiving handshake messages.

Powered by Google App Engine
This is Rietveld 408576698