chrome/test/data/extensions/api_test/cast_channel/api/test_open_timeout_verified.js - Issue 2974523002: [cast_channel] Make CastSocketService a global leaky singleton

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/cast_channel/api/test_open_timeout_verified.js

Issue 2974523002: [cast_channel] Make CastSocketService a global leaky singleton (Closed)

Patch Set: Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/media/router/discovery/mdns/cast_media_sink_service.cc ('K') | « chrome/test/data/extensions/api_test/cast_channel/api/test_open_timeout.js ('k') | components/cast_channel/BUILD.gn » ('j') | components/cast_channel/cast_socket.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/cast_channel/api/test_open_timeout_verified.js

diff --git a/chrome/test/data/extensions/api_test/cast_channel/api/test_open_timeout_verified.js b/chrome/test/data/extensions/api_test/cast_channel/api/test_open_timeout_verified.js

index 52b6a4dd972acc172b87250a413d36070dff1eed..f667b61cff3201c9f9945cf4368a6876637ea4be 100644

--- a/chrome/test/data/extensions/api_test/cast_channel/api/test_open_timeout_verified.js

+++ b/chrome/test/data/extensions/api_test/cast_channel/api/test_open_timeout_verified.js

@@ -17,7 +17,9 @@ chrome.cast.channel.open({

chrome.test.assertEq(channel.keepAlive, true);

if (channel.readyState == 'closed' &&

error.errorState == 'ping_timeout') {

- chrome.test.sendMessage('timeout_ssl_verified');

+ chrome.cast.channel.close(channel, () => {

+ chrome.test.sendMessage('timeout_ssl_verified');

+ });

}

});

chrome.test.notifyPass();