Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2974433002: Remaining private libs (Closed)

Created:
3 years, 5 months ago by Lasse Reichstein Nielsen
Modified:
3 years, 5 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remaining private libs Handle internal libraries correctly. Revert `part of "file.dart"` to `part of "dart:file"` to avoid warnings in fasta. BUG= R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/91db4489ee669aa713bc695d15fbbe0d7e3cdc16

Patch Set 1 #

Patch Set 2 : Change html_common. #

Patch Set 3 : It's html_common #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -145 lines) Patch
M sdk/lib/_internal/js_runtime/lib/annotations.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/js_runtime/lib/constant_map.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/js_runtime/lib/isolate_serialization.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/js_runtime/lib/js_array.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/js_runtime/lib/js_number.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/js_runtime/lib/js_rti.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/js_runtime/lib/js_string.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/js_runtime/lib/linked_hash_map.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/js_runtime/lib/native_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/js_runtime/lib/regexp_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/js_runtime/lib/string_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/async/async_error.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/async/broadcast_stream_controller.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/async/deferred_load.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/async/future.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/async/future_impl.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/async/schedule_microtask.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/async/stream.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/async/stream_controller.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/async/stream_impl.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/async/stream_pipe.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/async/stream_transformers.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/async/timer.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/async/zone.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/collection/collections.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/collection/hash_map.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/collection/hash_set.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/collection/iterable.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/collection/iterator.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/collection/linked_hash_map.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/collection/linked_hash_set.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/collection/linked_list.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/collection/list.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/collection/maps.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/collection/queue.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/collection/set.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/collection/splay_tree.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/convert/ascii.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/convert/base64.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/convert/byte_conversion.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/convert/chunked_conversion.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/convert/codec.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/convert/converter.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/convert/encoding.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/convert/html_escape.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/convert/json.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/convert/latin1.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/convert/line_splitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/convert/string_conversion.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/convert/utf.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/annotations.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/bool.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/comparable.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/date_time.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/double.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/duration.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/errors.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/exceptions.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/expando.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/function.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/identical.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/int.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/invocation.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/iterable.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/iterator.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/list.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/map.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/null.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/num.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/object.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/pattern.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/print.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/regexp.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/set.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/sink.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/stacktrace.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/stopwatch.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/string.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/string_buffer.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/string_sink.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/symbol.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/type.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/uri.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/developer/extension.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/developer/profiler.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/developer/service.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/developer/timeline.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/html/html_common/conversions.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/html/html_common/conversions_dart2js.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/html/html_common/conversions_dartium.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/html/html_common/css_class_set.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/html/html_common/device.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/html/html_common/filtered_element_list.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/html/html_common/lists.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/internal/iterable.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/internal/list.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/internal/print.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/internal/sort.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/internal/symbol.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/bytes_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/common.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/crypto.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/data_transformer.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/directory.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/directory_impl.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/eventhandler.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/file.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/file_impl.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/file_system_entity.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/http.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/http_date.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/http_headers.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/http_impl.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/http_parser.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/http_session.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/io_resource_info.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/io_service.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/io_sink.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/link.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/platform.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/platform_impl.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/process.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/secure_server_socket.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/secure_socket.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/security_context.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/service_object.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/socket.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/stdio.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/string_transformer.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/sync_socket.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/websocket.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/websocket_impl.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/isolate/capability.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/math/jenkins_smi_hash.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/math/point.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/math/random.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/math/rectangle.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/vmservice/asset.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/vmservice/client.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/vmservice/constants.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/vmservice/devfs.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/vmservice/message.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/vmservice/message_router.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/vmservice/running_isolate.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/vmservice/running_isolates.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Lasse Reichstein Nielsen
3 years, 5 months ago (2017-07-06 12:40:22 UTC) #2
floitsch
LGTM.
3 years, 5 months ago (2017-07-06 12:56:58 UTC) #3
Lasse Reichstein Nielsen
3 years, 5 months ago (2017-07-06 12:58:32 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
91db4489ee669aa713bc695d15fbbe0d7e3cdc16 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698