Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2974403002: Revert "Moves the top_ and end_ words of the Scavenger into mutator thread." (Closed)

Created:
3 years, 5 months ago by danunez
Modified:
3 years, 5 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Moves the top_ and end_ words of the Scavenger into mutator thread." This reverts commit 710544a9078e013aba49f0f00fc735526ac896bc. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/c0d4e026934c657404c80fd0b61be2750b78d719

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+230 lines, -236 lines) Patch
M runtime/vm/assembler_arm.cc View 3 chunks +11 lines, -8 lines 0 comments Download
M runtime/vm/assembler_arm64.cc View 2 chunks +10 lines, -8 lines 0 comments Download
M runtime/vm/assembler_ia32.cc View 3 chunks +10 lines, -8 lines 0 comments Download
M runtime/vm/assembler_x64.cc View 3 chunks +10 lines, -8 lines 0 comments Download
M runtime/vm/dart.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M runtime/vm/heap.h View 2 chunks +5 lines, -1 line 0 comments Download
M runtime/vm/heap.cc View 3 chunks +22 lines, -7 lines 0 comments Download
M runtime/vm/intrinsifier_arm.cc View 4 chunks +12 lines, -8 lines 0 comments Download
M runtime/vm/intrinsifier_arm64.cc View 4 chunks +12 lines, -8 lines 0 comments Download
M runtime/vm/intrinsifier_ia32.cc View 4 chunks +12 lines, -8 lines 0 comments Download
M runtime/vm/intrinsifier_x64.cc View 4 chunks +12 lines, -8 lines 0 comments Download
M runtime/vm/isolate.h View 1 chunk +0 lines, -7 lines 0 comments Download
M runtime/vm/isolate.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M runtime/vm/scavenger.h View 4 chunks +18 lines, -39 lines 0 comments Download
M runtime/vm/scavenger.cc View 9 chunks +2 lines, -39 lines 0 comments Download
M runtime/vm/scavenger_test.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M runtime/vm/stub_code_arm.cc View 5 chunks +18 lines, -12 lines 0 comments Download
M runtime/vm/stub_code_arm64.cc View 6 chunks +21 lines, -12 lines 0 comments Download
M runtime/vm/stub_code_ia32.cc View 4 chunks +17 lines, -12 lines 0 comments Download
M runtime/vm/stub_code_x64.cc View 5 chunks +19 lines, -12 lines 0 comments Download
M runtime/vm/thread.h View 2 chunks +0 lines, -17 lines 0 comments Download
M runtime/vm/thread.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
danunez
Committed patchset #1 (id:1) manually as c0d4e026934c657404c80fd0b61be2750b78d719 (presubmit successful).
3 years, 5 months ago (2017-07-12 21:30:17 UTC) #2
rmacnak
3 years, 5 months ago (2017-07-12 23:07:40 UTC) #3
Message was sent while issue was closed. 
lgtm

(Broke DBC)

Powered by Google App Engine
This is Rietveld 408576698