Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Side by Side Diff: net/cookies/cookie_monster.h

Issue 2974363002: Simplify CookieMonster::SetAllCookies{,Async}() implementation. (Closed)
Patch Set: Sync'd to p485987 Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | net/cookies/cookie_monster.cc » ('j') | net/cookies/cookie_monster.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Brought to you by the letter D and the number 2. 5 // Brought to you by the letter D and the number 2.
6 6
7 #ifndef NET_COOKIES_COOKIE_MONSTER_H_ 7 #ifndef NET_COOKIES_COOKIE_MONSTER_H_
8 #define NET_COOKIES_COOKIE_MONSTER_H_ 8 #define NET_COOKIES_COOKIE_MONSTER_H_
9 9
10 #include <stddef.h> 10 #include <stddef.h>
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
142 CookieMonsterDelegate* delegate, 142 CookieMonsterDelegate* delegate,
143 ChannelIDService* channel_id_service); 143 ChannelIDService* channel_id_service);
144 144
145 // Only used during unit testing. 145 // Only used during unit testing.
146 CookieMonster(PersistentCookieStore* store, 146 CookieMonster(PersistentCookieStore* store,
147 CookieMonsterDelegate* delegate, 147 CookieMonsterDelegate* delegate,
148 base::TimeDelta last_access_threshold); 148 base::TimeDelta last_access_threshold);
149 149
150 ~CookieMonster() override; 150 ~CookieMonster() override;
151 151
152 // Writes all the cookies in |list| into the store, replacing existing 152 // Writes all the cookies in |list| into the store, replacing all cookies
153 // cookies that collide. Does not affect cookies not listed in |list|. 153 // currently present in store.
154 // This method does not flush the backend. 154 // This method does not flush the backend.
155 // TODO(rdsmith, mmenke): Do not use this function; it is deprecated 155 // TODO(rdsmith, mmenke): Do not use this function; it is deprecated
156 // and should be removed. 156 // and should be removed.
157 // See https://codereview.chromium.org/2882063002/#msg64. 157 // See https://codereview.chromium.org/2882063002/#msg64.
158 void SetAllCookiesAsync(const CookieList& list, SetCookiesCallback callback); 158 void SetAllCookiesAsync(const CookieList& list, SetCookiesCallback callback);
159 159
160 // CookieStore implementation. 160 // CookieStore implementation.
161 void SetCookieWithOptionsAsync(const GURL& url, 161 void SetCookieWithOptionsAsync(const GURL& url,
162 const std::string& cookie_line, 162 const std::string& cookie_line,
163 const CookieOptions& options, 163 const CookieOptions& options,
(...skipping 644 matching lines...) Expand 10 before | Expand all | Expand 10 after
808 virtual ~PersistentCookieStore() {} 808 virtual ~PersistentCookieStore() {}
809 809
810 private: 810 private:
811 friend class base::RefCountedThreadSafe<PersistentCookieStore>; 811 friend class base::RefCountedThreadSafe<PersistentCookieStore>;
812 DISALLOW_COPY_AND_ASSIGN(PersistentCookieStore); 812 DISALLOW_COPY_AND_ASSIGN(PersistentCookieStore);
813 }; 813 };
814 814
815 } // namespace net 815 } // namespace net
816 816
817 #endif // NET_COOKIES_COOKIE_MONSTER_H_ 817 #endif // NET_COOKIES_COOKIE_MONSTER_H_
OLDNEW
« no previous file with comments | « no previous file | net/cookies/cookie_monster.cc » ('j') | net/cookies/cookie_monster.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698