Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1828)

Unified Diff: runtime/vm/kernel_reader.cc

Issue 2974233002: VM: Re-format to use at most one newline between functions (Closed)
Patch Set: Rebase and merge Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/kernel_isolate.cc ('k') | runtime/vm/kernel_to_il.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/kernel_reader.cc
diff --git a/runtime/vm/kernel_reader.cc b/runtime/vm/kernel_reader.cc
index b17dc4a9107dfc9606a5efaa33795e13d1448125..6d9a944cf86920a3c40ded06df66a65878284de7 100644
--- a/runtime/vm/kernel_reader.cc
+++ b/runtime/vm/kernel_reader.cc
@@ -32,7 +32,6 @@ class SimpleExpressionConverter {
simple_value_(NULL),
builder_(builder) {}
-
bool IsSimple(intptr_t kernel_offset) {
AlternativeReadingScope alt(builder_->reader_, kernel_offset);
uint8_t payload = 0;
@@ -98,7 +97,6 @@ class SimpleExpressionConverter {
StreamingFlowGraphBuilder* builder_;
};
-
RawArray* KernelReader::MakeFunctionsArray() {
const intptr_t len = functions_.length();
const Array& res = Array::Handle(zone_, Array::New(len, Heap::kOld));
@@ -108,18 +106,15 @@ RawArray* KernelReader::MakeFunctionsArray() {
return res.raw();
}
-
RawLibrary* BuildingTranslationHelper::LookupLibraryByKernelLibrary(
NameIndex library) {
return reader_->LookupLibrary(library).raw();
}
-
RawClass* BuildingTranslationHelper::LookupClassByKernelClass(NameIndex klass) {
return reader_->LookupClass(klass).raw();
}
-
KernelReader::KernelReader(Program* program)
: program_(program),
thread_(dart::Thread::Current()),
@@ -173,7 +168,6 @@ KernelReader::KernelReader(Program* program)
H.SetCanonicalNames(names);
}
-
Object& KernelReader::ReadProgram() {
LongJumpScope jump;
if (setjmp(*jump.Set()) == 0) {
@@ -212,7 +206,6 @@ Object& KernelReader::ReadProgram() {
return error;
}
-
void KernelReader::ReadLibrary(intptr_t kernel_offset) {
builder_.SetOffset(kernel_offset);
LibraryHelper library_helper(&builder_);
@@ -302,7 +295,6 @@ void KernelReader::ReadLibrary(intptr_t kernel_offset) {
classes.Add(toplevel_class, Heap::kOld);
}
-
void KernelReader::ReadPreliminaryClass(dart::Class* klass,
ClassHelper* class_helper,
intptr_t type_parameter_count) {
@@ -385,7 +377,6 @@ void KernelReader::ReadPreliminaryClass(dart::Class* klass,
if (class_helper->is_abstract_) klass->set_is_abstract();
}
-
dart::Class& KernelReader::ReadClass(const dart::Library& library,
const dart::Class& toplevel_class) {
ClassHelper class_helper(&builder_);
@@ -539,7 +530,6 @@ dart::Class& KernelReader::ReadClass(const dart::Library& library,
return klass;
}
-
void KernelReader::ReadProcedure(const dart::Library& library,
const dart::Class& owner,
bool in_class) {
@@ -812,7 +802,6 @@ void KernelReader::GenerateFieldAccessors(const dart::Class& klass,
}
}
-
void KernelReader::SetupFieldAccessorFunction(const dart::Class& klass,
const dart::Function& function) {
bool is_setter = function.IsImplicitSetterFunction();
@@ -839,7 +828,6 @@ void KernelReader::SetupFieldAccessorFunction(const dart::Class& klass,
}
}
-
dart::Library& KernelReader::LookupLibrary(NameIndex library) {
dart::Library* handle = NULL;
if (!libraries_.Lookup(library, &handle)) {
@@ -856,7 +844,6 @@ dart::Library& KernelReader::LookupLibrary(NameIndex library) {
return *handle;
}
-
dart::Class& KernelReader::LookupClass(NameIndex klass) {
dart::Class* handle = NULL;
if (!classes_.Lookup(klass, &handle)) {
@@ -876,7 +863,6 @@ dart::Class& KernelReader::LookupClass(NameIndex klass) {
return *handle;
}
-
RawFunction::Kind KernelReader::GetFunctionType(
Procedure::ProcedureKind procedure_kind) {
intptr_t lookuptable[] = {
@@ -895,7 +881,6 @@ RawFunction::Kind KernelReader::GetFunctionType(
}
}
-
ParsedFunction* ParseStaticFieldInitializer(Zone* zone,
const dart::Field& field) {
Thread* thread = Thread::Current();
@@ -922,7 +907,6 @@ ParsedFunction* ParseStaticFieldInitializer(Zone* zone,
return new (zone) ParsedFunction(thread, initializer_fun);
}
-
} // namespace kernel
} // namespace dart
#endif // !defined(DART_PRECOMPILED_RUNTIME)
« no previous file with comments | « runtime/vm/kernel_isolate.cc ('k') | runtime/vm/kernel_to_il.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698