Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1426)

Unified Diff: runtime/vm/dwarf.cc

Issue 2974233002: VM: Re-format to use at most one newline between functions (Closed)
Patch Set: Rebase and merge Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/double_conversion.cc ('k') | runtime/vm/exceptions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dwarf.cc
diff --git a/runtime/vm/dwarf.cc b/runtime/vm/dwarf.cc
index d5cd28fcf877477a44d4e45c0455b332a441a12d..2b2bf2af68b6fd3aa8a714d9cc62d4cf669176aa 100644
--- a/runtime/vm/dwarf.cc
+++ b/runtime/vm/dwarf.cc
@@ -48,7 +48,6 @@ class InliningNode : public ZoneAllocated {
InliningNode* children_next;
};
-
Dwarf::Dwarf(Zone* zone, WriteStream* stream)
: zone_(zone),
stream_(stream),
@@ -60,7 +59,6 @@ Dwarf::Dwarf(Zone* zone, WriteStream* stream)
script_to_index_(zone),
temp_(0) {}
-
intptr_t Dwarf::AddCode(const Code& code) {
ASSERT(!code.IsNull());
CodeIndexPair* pair = code_to_index_.Lookup(&code);
@@ -87,7 +85,6 @@ intptr_t Dwarf::AddCode(const Code& code) {
return index;
}
-
intptr_t Dwarf::AddFunction(const Function& function) {
ASSERT(!function.IsNull());
FunctionIndexPair* pair = function_to_index_.Lookup(&function);
@@ -103,7 +100,6 @@ intptr_t Dwarf::AddFunction(const Function& function) {
return index;
}
-
intptr_t Dwarf::AddScript(const Script& script) {
ASSERT(!script.IsNull());
ScriptIndexPair* pair = script_to_index_.Lookup(&script);
@@ -118,7 +114,6 @@ intptr_t Dwarf::AddScript(const Script& script) {
return index;
}
-
intptr_t Dwarf::LookupFunction(const Function& function) {
ASSERT(!function.IsNull());
FunctionIndexPair* pair = function_to_index_.Lookup(&function);
@@ -129,7 +124,6 @@ intptr_t Dwarf::LookupFunction(const Function& function) {
return pair->index_;
}
-
intptr_t Dwarf::LookupScript(const Script& script) {
ASSERT(!script.IsNull());
ScriptIndexPair* pair = script_to_index_.Lookup(&script);
@@ -140,7 +134,6 @@ intptr_t Dwarf::LookupScript(const Script& script) {
return pair->index_;
}
-
void Dwarf::Print(const char* format, ...) {
va_list args;
va_start(args, format);
@@ -148,7 +141,6 @@ void Dwarf::Print(const char* format, ...) {
va_end(args);
}
-
void Dwarf::WriteAbbreviations() {
// Dwarf data mostly takes the form of a tree, whose nodes are called
// DIEs. Each DIE begins with an abbreviation code, and the abbreviation
@@ -226,7 +218,6 @@ void Dwarf::WriteAbbreviations() {
uleb128(0); // End of abbreviations.
}
-
void Dwarf::WriteCompilationUnit() {
// 7.5.1.1 Compilation Unit Header
@@ -289,7 +280,6 @@ void Dwarf::WriteCompilationUnit() {
Print(".Lcu_end:\n");
}
-
void Dwarf::WriteAbstractFunctions() {
Script& script = Script::Handle(zone_);
String& name = String::Handle(zone_);
@@ -310,7 +300,6 @@ void Dwarf::WriteAbstractFunctions() {
}
}
-
void Dwarf::WriteConcreteFunctions() {
Function& function = Function::Handle(zone_);
Script& script = Script::Handle(zone_);
@@ -349,7 +338,6 @@ void Dwarf::WriteConcreteFunctions() {
}
}
-
// Our state machine encodes position metadata such that we don't know the
// end pc for an inlined function until it is popped, but DWARF DIEs encode
// it where the function is pushed. We expand the state transitions into
@@ -424,7 +412,6 @@ InliningNode* Dwarf::ExpandInliningTree(const Code& code) {
return root_node;
}
-
void Dwarf::WriteInliningNode(InliningNode* node,
intptr_t root_code_index,
const Script& parent_script) {
@@ -459,7 +446,6 @@ void Dwarf::WriteInliningNode(InliningNode* node,
uleb128(0); // End of children.
}
-
void Dwarf::WriteLines() {
#if defined(TARGET_OS_MACOS) || defined(TARGET_OS_MACOS_IOS)
Print(".section __DWARF,__debug_line,regular,debug\n");
« no previous file with comments | « runtime/vm/double_conversion.cc ('k') | runtime/vm/exceptions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698