Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Unified Diff: runtime/vm/flags.cc

Issue 2974233002: VM: Re-format to use at most one newline between functions (Closed)
Patch Set: Rebase and merge Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flags.h ('k') | runtime/vm/flags_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flags.cc
diff --git a/runtime/vm/flags.cc b/runtime/vm/flags.cc
index 5c7d24675385ce0ecd2dc140aac6a1d22b1d4abf..998d322f8bf18991dca655f79887fd9af4b6e880 100644
--- a/runtime/vm/flags.cc
+++ b/runtime/vm/flags.cc
@@ -60,7 +60,6 @@ DEFINE_FLAG(bool,
Flags::Register_##type(&FLAG_##name, #name, default_value, comment);
#endif
-
// Define all of the non-product flags here.
FLAG_LIST(PRODUCT_FLAG_MARCO,
RELEASE_FLAG_MARCO,
@@ -72,7 +71,6 @@ FLAG_LIST(PRODUCT_FLAG_MARCO,
#undef PRODUCT_FLAG_MARCO
#undef PRECOMPILE_FLAG_MARCO
-
bool Flags::initialized_ = false;
// List of registered flags.
@@ -144,7 +142,6 @@ class Flag {
bool changed_;
};
-
Flag* Flags::Lookup(const char* name) {
for (intptr_t i = 0; i < num_flags_; i++) {
Flag* flag = flags_[i];
@@ -155,14 +152,12 @@ Flag* Flags::Lookup(const char* name) {
return NULL;
}
-
bool Flags::IsSet(const char* name) {
Flag* flag = Lookup(name);
return (flag != NULL) && (flag->type_ == Flag::kBoolean) &&
(flag->bool_ptr_ != NULL) && (*flag->bool_ptr_ == true);
}
-
void Flags::AddFlag(Flag* flag) {
ASSERT(!initialized_);
if (num_flags_ == capacity_) {
@@ -183,7 +178,6 @@ void Flags::AddFlag(Flag* flag) {
flags_[num_flags_++] = flag;
}
-
bool Flags::Register_bool(bool* addr,
const char* name,
bool default_value,
@@ -198,7 +192,6 @@ bool Flags::Register_bool(bool* addr,
return default_value;
}
-
int Flags::Register_int(int* addr,
const char* name,
int default_value,
@@ -211,7 +204,6 @@ int Flags::Register_int(int* addr,
return default_value;
}
-
uint64_t Flags::Register_uint64_t(uint64_t* addr,
const char* name,
uint64_t default_value,
@@ -224,7 +216,6 @@ uint64_t Flags::Register_uint64_t(uint64_t* addr,
return default_value;
}
-
const char* Flags::Register_charp(charp* addr,
const char* name,
const char* default_value,
@@ -235,7 +226,6 @@ const char* Flags::Register_charp(charp* addr,
return default_value;
}
-
bool Flags::Register_func(FlagHandler handler,
const char* name,
const char* comment) {
@@ -245,7 +235,6 @@ bool Flags::Register_func(FlagHandler handler,
return false;
}
-
static void Normalize(char* s) {
intptr_t len = strlen(s);
for (intptr_t i = 0; i < len; i++) {
@@ -255,7 +244,6 @@ static void Normalize(char* s) {
}
}
-
bool Flags::SetFlagFromString(Flag* flag, const char* argument) {
ASSERT(!flag->IsUnrecognized());
switch (flag->type_) {
@@ -322,7 +310,6 @@ bool Flags::SetFlagFromString(Flag* flag, const char* argument) {
return true;
}
-
void Flags::Parse(const char* option) {
// Find the beginning of the option argument, if it exists.
const char* equals = option;
@@ -382,7 +369,6 @@ void Flags::Parse(const char* option) {
delete[] name;
}
-
static bool IsValidFlag(const char* name,
const char* prefix,
intptr_t prefix_length) {
@@ -391,14 +377,12 @@ static bool IsValidFlag(const char* name,
(strncmp(name, prefix, prefix_length) == 0));
}
-
int Flags::CompareFlagNames(const void* left, const void* right) {
const Flag* left_flag = *reinterpret_cast<const Flag* const*>(left);
const Flag* right_flag = *reinterpret_cast<const Flag* const*>(right);
return strcmp(left_flag->name_, right_flag->name_);
}
-
bool Flags::ProcessCommandLineFlags(int number_of_vm_flags,
const char** vm_flags) {
if (initialized_) {
@@ -444,7 +428,6 @@ bool Flags::ProcessCommandLineFlags(int number_of_vm_flags,
return true;
}
-
bool Flags::SetFlag(const char* name, const char* value, const char** error) {
Flag* flag = Lookup(name);
if (flag == NULL) {
@@ -458,7 +441,6 @@ bool Flags::SetFlag(const char* name, const char* value, const char** error) {
return true;
}
-
void Flags::PrintFlags() {
OS::Print("Flag settings:\n");
for (intptr_t i = 0; i < num_flags_; ++i) {
@@ -466,7 +448,6 @@ void Flags::PrintFlags() {
}
}
-
#ifndef PRODUCT
void Flags::PrintFlagToJSONArray(JSONArray* jsarr, const Flag* flag) {
if (!FLAG_support_service) {
@@ -511,7 +492,6 @@ void Flags::PrintFlagToJSONArray(JSONArray* jsarr, const Flag* flag) {
}
}
-
void Flags::PrintJSON(JSONStream* js) {
if (!FLAG_support_service) {
return;
« no previous file with comments | « runtime/vm/flags.h ('k') | runtime/vm/flags_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698