Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: runtime/vm/source_report.cc

Issue 2974233002: VM: Re-format to use at most one newline between functions (Closed)
Patch Set: Rebase and merge Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/snapshot_test.cc ('k') | runtime/vm/source_report_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/source_report.cc
diff --git a/runtime/vm/source_report.cc b/runtime/vm/source_report.cc
index 33911b1044789cadea2b78633cf911d3c3e27683..e703cfab97e3301af991380b529f8b0246545046 100644
--- a/runtime/vm/source_report.cc
+++ b/runtime/vm/source_report.cc
@@ -28,12 +28,10 @@ SourceReport::SourceReport(intptr_t report_set, CompileMode compile_mode)
profile_(Isolate::Current()),
next_script_index_(0) {}
-
SourceReport::~SourceReport() {
ClearScriptTable();
}
-
void SourceReport::ClearScriptTable() {
for (intptr_t i = 0; i < script_table_entries_.length(); i++) {
delete script_table_entries_[i];
@@ -44,7 +42,6 @@ void SourceReport::ClearScriptTable() {
next_script_index_ = 0;
}
-
void SourceReport::Init(Thread* thread,
const Script* script,
TokenPosition start_pos,
@@ -63,12 +60,10 @@ void SourceReport::Init(Thread* thread,
}
}
-
bool SourceReport::IsReportRequested(ReportKind report_kind) {
return (report_set_ & report_kind) != 0;
}
-
bool SourceReport::ShouldSkipFunction(const Function& func) {
if (script_ != NULL && !script_->IsNull()) {
if (func.script() != script_->raw()) {
@@ -108,7 +103,6 @@ bool SourceReport::ShouldSkipFunction(const Function& func) {
return false;
}
-
intptr_t SourceReport::GetScriptIndex(const Script& script) {
const String& url = String::Handle(zone(), script.url());
ScriptTableEntry* pair = script_table_.LookupValue(&url);
@@ -128,7 +122,6 @@ intptr_t SourceReport::GetScriptIndex(const Script& script) {
return tmp->index;
}
-
#if defined(DEBUG)
void SourceReport::VerifyScriptTable() {
for (intptr_t i = 0; i < script_table_entries_.length(); i++) {
@@ -144,7 +137,6 @@ void SourceReport::VerifyScriptTable() {
}
#endif
-
bool SourceReport::ScriptIsLoadedByLibrary(const Script& script,
const Library& lib) {
const Array& scripts = Array::Handle(zone(), lib.LoadedScripts());
@@ -156,7 +148,6 @@ bool SourceReport::ScriptIsLoadedByLibrary(const Script& script,
return false;
}
-
void SourceReport::PrintCallSitesData(JSONObject* jsobj,
const Function& function,
const Code& code) {
@@ -196,7 +187,6 @@ void SourceReport::PrintCallSitesData(JSONObject* jsobj,
}
}
-
void SourceReport::PrintCoverageData(JSONObject* jsobj,
const Function& function,
const Code& code) {
@@ -273,7 +263,6 @@ void SourceReport::PrintCoverageData(JSONObject* jsobj,
}
}
-
void SourceReport::PrintPossibleBreakpointsData(JSONObject* jsobj,
const Function& func,
const Code& code) {
@@ -313,7 +302,6 @@ void SourceReport::PrintPossibleBreakpointsData(JSONObject* jsobj,
}
}
-
void SourceReport::PrintProfileData(JSONObject* jsobj,
ProfileFunction* profile_function) {
ASSERT(profile_function != NULL);
@@ -364,7 +352,6 @@ void SourceReport::PrintProfileData(JSONObject* jsobj,
}
}
-
void SourceReport::PrintScriptTable(JSONArray* scripts) {
for (intptr_t i = 0; i < script_table_entries_.length(); i++) {
const Script* script = script_table_entries_[i]->script;
@@ -372,7 +359,6 @@ void SourceReport::PrintScriptTable(JSONArray* scripts) {
}
}
-
void SourceReport::VisitFunction(JSONArray* jsarr, const Function& func) {
if (ShouldSkipFunction(func)) {
return;
@@ -442,7 +428,6 @@ void SourceReport::VisitFunction(JSONArray* jsarr, const Function& func) {
}
}
-
void SourceReport::VisitLibrary(JSONArray* jsarr, const Library& lib) {
Class& cls = Class::Handle(zone());
Array& functions = Array::Handle(zone());
@@ -485,7 +470,6 @@ void SourceReport::VisitLibrary(JSONArray* jsarr, const Library& lib) {
}
}
-
void SourceReport::VisitClosures(JSONArray* jsarr) {
const GrowableObjectArray& closures = GrowableObjectArray::Handle(
thread()->isolate()->object_store()->closure_functions());
@@ -499,7 +483,6 @@ void SourceReport::VisitClosures(JSONArray* jsarr) {
}
}
-
void SourceReport::PrintJSON(JSONStream* js,
const Script& script,
TokenPosition start_pos,
« no previous file with comments | « runtime/vm/snapshot_test.cc ('k') | runtime/vm/source_report_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698