Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/bin/file.cc

Issue 2974233002: VM: Re-format to use at most one newline between functions (Closed)
Patch Set: Rebase and merge Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/fdutils_macos.cc ('k') | runtime/bin/file_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/file.cc
diff --git a/runtime/bin/file.cc b/runtime/bin/file.cc
index feeb130fec57106d5851ef6b3fde0b32920e0b55..d512671c227ac557234a1a7f05452e693c7a0ef2 100644
--- a/runtime/bin/file.cc
+++ b/runtime/bin/file.cc
@@ -32,7 +32,6 @@ static File* GetFile(Dart_NativeArguments args) {
return file;
}
-
static void SetFile(Dart_Handle dart_this, intptr_t file_pointer) {
Dart_Handle result = Dart_SetNativeInstanceField(
dart_this, kFileNativeFieldIndex, file_pointer);
@@ -42,7 +41,6 @@ static void SetFile(Dart_Handle dart_this, intptr_t file_pointer) {
}
}
-
void FUNCTION_NAME(File_GetPointer)(Dart_NativeArguments args) {
File* file = GetFile(args);
// If the file is already closed, GetFile() will return NULL.
@@ -55,7 +53,6 @@ void FUNCTION_NAME(File_GetPointer)(Dart_NativeArguments args) {
Dart_SetReturnValue(args, Dart_NewInteger(file_pointer));
}
-
static void ReleaseFile(void* isolate_callback_data,
Dart_WeakPersistentHandle handle,
void* peer) {
@@ -63,7 +60,6 @@ static void ReleaseFile(void* isolate_callback_data,
file->Release();
}
-
void FUNCTION_NAME(File_SetPointer)(Dart_NativeArguments args) {
Dart_Handle dart_this = ThrowIfError(Dart_GetNativeArgument(args, 0));
intptr_t file_pointer =
@@ -75,7 +71,6 @@ void FUNCTION_NAME(File_SetPointer)(Dart_NativeArguments args) {
SetFile(dart_this, file_pointer);
}
-
void FUNCTION_NAME(File_Open)(Dart_NativeArguments args) {
const char* filename =
DartUtils::GetStringValue(Dart_GetNativeArgument(args, 0));
@@ -96,7 +91,6 @@ void FUNCTION_NAME(File_Open)(Dart_NativeArguments args) {
}
}
-
void FUNCTION_NAME(File_Exists)(Dart_NativeArguments args) {
const char* filename =
DartUtils::GetStringValue(Dart_GetNativeArgument(args, 0));
@@ -104,7 +98,6 @@ void FUNCTION_NAME(File_Exists)(Dart_NativeArguments args) {
Dart_SetReturnValue(args, Dart_NewBoolean(exists));
}
-
void FUNCTION_NAME(File_Close)(Dart_NativeArguments args) {
File* file = GetFile(args);
ASSERT(file != NULL);
@@ -118,7 +111,6 @@ void FUNCTION_NAME(File_Close)(Dart_NativeArguments args) {
Dart_SetReturnValue(args, Dart_NewInteger(0));
}
-
void FUNCTION_NAME(File_ReadByte)(Dart_NativeArguments args) {
File* file = GetFile(args);
ASSERT(file != NULL);
@@ -133,7 +125,6 @@ void FUNCTION_NAME(File_ReadByte)(Dart_NativeArguments args) {
}
}
-
void FUNCTION_NAME(File_WriteByte)(Dart_NativeArguments args) {
File* file = GetFile(args);
ASSERT(file != NULL);
@@ -152,7 +143,6 @@ void FUNCTION_NAME(File_WriteByte)(Dart_NativeArguments args) {
}
}
-
void FUNCTION_NAME(File_Read)(Dart_NativeArguments args) {
File* file = GetFile(args);
ASSERT(file != NULL);
@@ -191,7 +181,6 @@ void FUNCTION_NAME(File_Read)(Dart_NativeArguments args) {
}
}
-
void FUNCTION_NAME(File_ReadInto)(Dart_NativeArguments args) {
File* file = GetFile(args);
ASSERT(file != NULL);
@@ -224,7 +213,6 @@ void FUNCTION_NAME(File_ReadInto)(Dart_NativeArguments args) {
}
}
-
void FUNCTION_NAME(File_WriteFrom)(Dart_NativeArguments args) {
File* file = GetFile(args);
ASSERT(file != NULL);
@@ -271,7 +259,6 @@ void FUNCTION_NAME(File_WriteFrom)(Dart_NativeArguments args) {
}
}
-
void FUNCTION_NAME(File_Position)(Dart_NativeArguments args) {
File* file = GetFile(args);
ASSERT(file != NULL);
@@ -283,7 +270,6 @@ void FUNCTION_NAME(File_Position)(Dart_NativeArguments args) {
}
}
-
void FUNCTION_NAME(File_SetPosition)(Dart_NativeArguments args) {
File* file = GetFile(args);
ASSERT(file != NULL);
@@ -300,7 +286,6 @@ void FUNCTION_NAME(File_SetPosition)(Dart_NativeArguments args) {
}
}
-
void FUNCTION_NAME(File_Truncate)(Dart_NativeArguments args) {
File* file = GetFile(args);
ASSERT(file != NULL);
@@ -317,7 +302,6 @@ void FUNCTION_NAME(File_Truncate)(Dart_NativeArguments args) {
}
}
-
void FUNCTION_NAME(File_Length)(Dart_NativeArguments args) {
File* file = GetFile(args);
ASSERT(file != NULL);
@@ -329,7 +313,6 @@ void FUNCTION_NAME(File_Length)(Dart_NativeArguments args) {
}
}
-
void FUNCTION_NAME(File_LengthFromPath)(Dart_NativeArguments args) {
const char* path = DartUtils::GetStringValue(Dart_GetNativeArgument(args, 0));
int64_t return_value = File::LengthFromPath(path);
@@ -340,7 +323,6 @@ void FUNCTION_NAME(File_LengthFromPath)(Dart_NativeArguments args) {
}
}
-
void FUNCTION_NAME(File_LastModified)(Dart_NativeArguments args) {
const char* name = DartUtils::GetStringValue(Dart_GetNativeArgument(args, 0));
int64_t return_value = File::LastModified(name);
@@ -352,7 +334,6 @@ void FUNCTION_NAME(File_LastModified)(Dart_NativeArguments args) {
}
}
-
void FUNCTION_NAME(File_SetLastModified)(Dart_NativeArguments args) {
const char* name = DartUtils::GetStringValue(Dart_GetNativeArgument(args, 0));
int64_t millis;
@@ -365,7 +346,6 @@ void FUNCTION_NAME(File_SetLastModified)(Dart_NativeArguments args) {
}
}
-
void FUNCTION_NAME(File_LastAccessed)(Dart_NativeArguments args) {
const char* name = DartUtils::GetStringValue(Dart_GetNativeArgument(args, 0));
int64_t return_value = File::LastAccessed(name);
@@ -377,7 +357,6 @@ void FUNCTION_NAME(File_LastAccessed)(Dart_NativeArguments args) {
}
}
-
void FUNCTION_NAME(File_SetLastAccessed)(Dart_NativeArguments args) {
const char* name = DartUtils::GetStringValue(Dart_GetNativeArgument(args, 0));
int64_t millis;
@@ -390,7 +369,6 @@ void FUNCTION_NAME(File_SetLastAccessed)(Dart_NativeArguments args) {
}
}
-
void FUNCTION_NAME(File_Flush)(Dart_NativeArguments args) {
File* file = GetFile(args);
ASSERT(file != NULL);
@@ -401,7 +379,6 @@ void FUNCTION_NAME(File_Flush)(Dart_NativeArguments args) {
}
}
-
void FUNCTION_NAME(File_Lock)(Dart_NativeArguments args) {
File* file = GetFile(args);
ASSERT(file != NULL);
@@ -425,7 +402,6 @@ void FUNCTION_NAME(File_Lock)(Dart_NativeArguments args) {
Dart_SetReturnValue(args, DartUtils::NewDartOSError(&os_error));
}
-
void FUNCTION_NAME(File_Create)(Dart_NativeArguments args) {
const char* str = DartUtils::GetStringValue(Dart_GetNativeArgument(args, 0));
bool result = File::Create(str);
@@ -436,7 +412,6 @@ void FUNCTION_NAME(File_Create)(Dart_NativeArguments args) {
}
}
-
void FUNCTION_NAME(File_CreateLink)(Dart_NativeArguments args) {
if (Dart_IsString(Dart_GetNativeArgument(args, 0)) &&
Dart_IsString(Dart_GetNativeArgument(args, 1))) {
@@ -454,7 +429,6 @@ void FUNCTION_NAME(File_CreateLink)(Dart_NativeArguments args) {
}
}
-
void FUNCTION_NAME(File_LinkTarget)(Dart_NativeArguments args) {
if (Dart_IsString(Dart_GetNativeArgument(args, 0))) {
const char* name =
@@ -472,7 +446,6 @@ void FUNCTION_NAME(File_LinkTarget)(Dart_NativeArguments args) {
}
}
-
void FUNCTION_NAME(File_Delete)(Dart_NativeArguments args) {
const char* str = DartUtils::GetStringValue(Dart_GetNativeArgument(args, 0));
bool result = File::Delete(str);
@@ -483,7 +456,6 @@ void FUNCTION_NAME(File_Delete)(Dart_NativeArguments args) {
}
}
-
void FUNCTION_NAME(File_DeleteLink)(Dart_NativeArguments args) {
const char* str = DartUtils::GetStringValue(Dart_GetNativeArgument(args, 0));
bool result = File::DeleteLink(str);
@@ -494,7 +466,6 @@ void FUNCTION_NAME(File_DeleteLink)(Dart_NativeArguments args) {
}
}
-
void FUNCTION_NAME(File_Rename)(Dart_NativeArguments args) {
const char* old_path =
DartUtils::GetStringValue(Dart_GetNativeArgument(args, 0));
@@ -508,7 +479,6 @@ void FUNCTION_NAME(File_Rename)(Dart_NativeArguments args) {
}
}
-
void FUNCTION_NAME(File_RenameLink)(Dart_NativeArguments args) {
const char* old_path =
DartUtils::GetStringValue(Dart_GetNativeArgument(args, 0));
@@ -522,7 +492,6 @@ void FUNCTION_NAME(File_RenameLink)(Dart_NativeArguments args) {
}
}
-
void FUNCTION_NAME(File_Copy)(Dart_NativeArguments args) {
const char* old_path =
DartUtils::GetStringValue(Dart_GetNativeArgument(args, 0));
@@ -536,7 +505,6 @@ void FUNCTION_NAME(File_Copy)(Dart_NativeArguments args) {
}
}
-
void FUNCTION_NAME(File_ResolveSymbolicLinks)(Dart_NativeArguments args) {
const char* str = DartUtils::GetStringValue(Dart_GetNativeArgument(args, 0));
const char* path = File::GetCanonicalPath(str);
@@ -547,7 +515,6 @@ void FUNCTION_NAME(File_ResolveSymbolicLinks)(Dart_NativeArguments args) {
}
}
-
void FUNCTION_NAME(File_OpenStdio)(Dart_NativeArguments args) {
int64_t fd = DartUtils::GetIntegerValue(Dart_GetNativeArgument(args, 0));
ASSERT((fd == STDIN_FILENO) || (fd == STDOUT_FILENO) ||
@@ -556,7 +523,6 @@ void FUNCTION_NAME(File_OpenStdio)(Dart_NativeArguments args) {
Dart_SetReturnValue(args, Dart_NewInteger(reinterpret_cast<intptr_t>(file)));
}
-
void FUNCTION_NAME(File_GetStdioHandleType)(Dart_NativeArguments args) {
int64_t fd = DartUtils::GetIntegerValue(Dart_GetNativeArgument(args, 0));
ASSERT((fd == STDIN_FILENO) || (fd == STDOUT_FILENO) ||
@@ -565,7 +531,6 @@ void FUNCTION_NAME(File_GetStdioHandleType)(Dart_NativeArguments args) {
Dart_SetReturnValue(args, Dart_NewInteger(type));
}
-
void FUNCTION_NAME(File_GetType)(Dart_NativeArguments args) {
if (Dart_IsString(Dart_GetNativeArgument(args, 0)) &&
Dart_IsBoolean(Dart_GetNativeArgument(args, 1))) {
@@ -582,7 +547,6 @@ void FUNCTION_NAME(File_GetType)(Dart_NativeArguments args) {
}
}
-
void FUNCTION_NAME(File_Stat)(Dart_NativeArguments args) {
if (Dart_IsString(Dart_GetNativeArgument(args, 0))) {
const char* path =
@@ -621,7 +585,6 @@ void FUNCTION_NAME(File_Stat)(Dart_NativeArguments args) {
}
}
-
void FUNCTION_NAME(File_AreIdentical)(Dart_NativeArguments args) {
if (Dart_IsString(Dart_GetNativeArgument(args, 0)) &&
Dart_IsString(Dart_GetNativeArgument(args, 1))) {
@@ -642,7 +605,6 @@ void FUNCTION_NAME(File_AreIdentical)(Dart_NativeArguments args) {
}
}
-
static int64_t CObjectInt32OrInt64ToInt64(CObject* cobject) {
ASSERT(cobject->IsInt32OrInt64());
int64_t result;
@@ -656,13 +618,11 @@ static int64_t CObjectInt32OrInt64ToInt64(CObject* cobject) {
return result;
}
-
File* CObjectToFilePointer(CObject* cobject) {
CObjectIntptr value(cobject);
return reinterpret_cast<File*>(value.Value());
}
-
CObject* File::ExistsRequest(const CObjectArray& request) {
if ((request.Length() == 1) && request[0]->IsString()) {
CObjectString filename(request[0]);
@@ -672,7 +632,6 @@ CObject* File::ExistsRequest(const CObjectArray& request) {
return CObject::IllegalArgumentError();
}
-
CObject* File::CreateRequest(const CObjectArray& request) {
if ((request.Length() == 1) && request[0]->IsString()) {
CObjectString filename(request[0]);
@@ -686,7 +645,6 @@ CObject* File::CreateRequest(const CObjectArray& request) {
return CObject::IllegalArgumentError();
}
-
CObject* File::OpenRequest(const CObjectArray& request) {
File* file = NULL;
if ((request.Length() == 2) && request[0]->IsString() &&
@@ -707,7 +665,6 @@ CObject* File::OpenRequest(const CObjectArray& request) {
return CObject::IllegalArgumentError();
}
-
CObject* File::DeleteRequest(const CObjectArray& request) {
if ((request.Length() == 1) && request[0]->IsString()) {
CObjectString filename(request[0]);
@@ -721,7 +678,6 @@ CObject* File::DeleteRequest(const CObjectArray& request) {
return CObject::False();
}
-
CObject* File::RenameRequest(const CObjectArray& request) {
if ((request.Length() == 2) && request[0]->IsString() &&
request[1]->IsString()) {
@@ -736,7 +692,6 @@ CObject* File::RenameRequest(const CObjectArray& request) {
return CObject::IllegalArgumentError();
}
-
CObject* File::CopyRequest(const CObjectArray& request) {
if ((request.Length() == 2) && request[0]->IsString() &&
request[1]->IsString()) {
@@ -751,7 +706,6 @@ CObject* File::CopyRequest(const CObjectArray& request) {
return CObject::IllegalArgumentError();
}
-
CObject* File::ResolveSymbolicLinksRequest(const CObjectArray& request) {
if ((request.Length() == 1) && request[0]->IsString()) {
CObjectString filename(request[0]);
@@ -766,7 +720,6 @@ CObject* File::ResolveSymbolicLinksRequest(const CObjectArray& request) {
return CObject::IllegalArgumentError();
}
-
CObject* File::CloseRequest(const CObjectArray& request) {
intptr_t return_value = -1;
if ((request.Length() == 1) && request[0]->IsIntptr()) {
@@ -785,7 +738,6 @@ CObject* File::CloseRequest(const CObjectArray& request) {
return new CObjectIntptr(CObject::NewIntptr(return_value));
}
-
CObject* File::PositionRequest(const CObjectArray& request) {
if ((request.Length() == 1) && request[0]->IsIntptr()) {
File* file = CObjectToFilePointer(request[0]);
@@ -804,7 +756,6 @@ CObject* File::PositionRequest(const CObjectArray& request) {
return CObject::IllegalArgumentError();
}
-
CObject* File::SetPositionRequest(const CObjectArray& request) {
if ((request.Length() >= 1) && request[0]->IsIntptr()) {
File* file = CObjectToFilePointer(request[0]);
@@ -827,7 +778,6 @@ CObject* File::SetPositionRequest(const CObjectArray& request) {
return CObject::IllegalArgumentError();
}
-
CObject* File::TruncateRequest(const CObjectArray& request) {
if ((request.Length() >= 1) && request[0]->IsIntptr()) {
File* file = CObjectToFilePointer(request[0]);
@@ -850,7 +800,6 @@ CObject* File::TruncateRequest(const CObjectArray& request) {
return CObject::IllegalArgumentError();
}
-
CObject* File::LengthRequest(const CObjectArray& request) {
if ((request.Length() == 1) && request[0]->IsIntptr()) {
File* file = CObjectToFilePointer(request[0]);
@@ -869,7 +818,6 @@ CObject* File::LengthRequest(const CObjectArray& request) {
return CObject::IllegalArgumentError();
}
-
CObject* File::LengthFromPathRequest(const CObjectArray& request) {
if ((request.Length() == 1) && request[0]->IsString()) {
CObjectString filepath(request[0]);
@@ -883,7 +831,6 @@ CObject* File::LengthFromPathRequest(const CObjectArray& request) {
return CObject::IllegalArgumentError();
}
-
CObject* File::LastAccessedRequest(const CObjectArray& request) {
if ((request.Length() == 1) && request[0]->IsString()) {
CObjectString filepath(request[0]);
@@ -898,7 +845,6 @@ CObject* File::LastAccessedRequest(const CObjectArray& request) {
return CObject::IllegalArgumentError();
}
-
CObject* File::SetLastAccessedRequest(const CObjectArray& request) {
if ((request.Length() == 2) && request[0]->IsString() &&
request[1]->IsInt32OrInt64()) {
@@ -913,7 +859,6 @@ CObject* File::SetLastAccessedRequest(const CObjectArray& request) {
return CObject::IllegalArgumentError();
}
-
CObject* File::LastModifiedRequest(const CObjectArray& request) {
if ((request.Length() == 1) && request[0]->IsString()) {
CObjectString filepath(request[0]);
@@ -928,7 +873,6 @@ CObject* File::LastModifiedRequest(const CObjectArray& request) {
return CObject::IllegalArgumentError();
}
-
CObject* File::SetLastModifiedRequest(const CObjectArray& request) {
if ((request.Length() == 2) && request[0]->IsString() &&
request[1]->IsInt32OrInt64()) {
@@ -943,7 +887,6 @@ CObject* File::SetLastModifiedRequest(const CObjectArray& request) {
return CObject::IllegalArgumentError();
}
-
CObject* File::FlushRequest(const CObjectArray& request) {
if ((request.Length() == 1) && request[0]->IsIntptr()) {
File* file = CObjectToFilePointer(request[0]);
@@ -961,7 +904,6 @@ CObject* File::FlushRequest(const CObjectArray& request) {
return CObject::IllegalArgumentError();
}
-
CObject* File::ReadByteRequest(const CObjectArray& request) {
if ((request.Length() == 1) && request[0]->IsIntptr()) {
File* file = CObjectToFilePointer(request[0]);
@@ -983,7 +925,6 @@ CObject* File::ReadByteRequest(const CObjectArray& request) {
return CObject::IllegalArgumentError();
}
-
CObject* File::WriteByteRequest(const CObjectArray& request) {
if ((request.Length() >= 1) && request[0]->IsIntptr()) {
File* file = CObjectToFilePointer(request[0]);
@@ -1008,7 +949,6 @@ CObject* File::WriteByteRequest(const CObjectArray& request) {
return CObject::IllegalArgumentError();
}
-
CObject* File::ReadRequest(const CObjectArray& request) {
if ((request.Length() >= 1) && request[0]->IsIntptr()) {
File* file = CObjectToFilePointer(request[0]);
@@ -1042,7 +982,6 @@ CObject* File::ReadRequest(const CObjectArray& request) {
return CObject::IllegalArgumentError();
}
-
CObject* File::ReadIntoRequest(const CObjectArray& request) {
if ((request.Length() >= 1) && request[0]->IsIntptr()) {
File* file = CObjectToFilePointer(request[0]);
@@ -1077,7 +1016,6 @@ CObject* File::ReadIntoRequest(const CObjectArray& request) {
return CObject::IllegalArgumentError();
}
-
static int SizeInBytes(Dart_TypedData_Type type) {
switch (type) {
case Dart_TypedData_kInt8:
@@ -1102,7 +1040,6 @@ static int SizeInBytes(Dart_TypedData_Type type) {
return -1;
}
-
CObject* File::WriteFromRequest(const CObjectArray& request) {
if ((request.Length() >= 1) && request[0]->IsIntptr()) {
File* file = CObjectToFilePointer(request[0]);
@@ -1151,7 +1088,6 @@ CObject* File::WriteFromRequest(const CObjectArray& request) {
return CObject::IllegalArgumentError();
}
-
CObject* File::CreateLinkRequest(const CObjectArray& request) {
if ((request.Length() != 2) || !request[0]->IsString() ||
!request[1]->IsString()) {
@@ -1166,7 +1102,6 @@ CObject* File::CreateLinkRequest(const CObjectArray& request) {
}
}
-
CObject* File::DeleteLinkRequest(const CObjectArray& request) {
if ((request.Length() == 1) && request[0]->IsString()) {
CObjectString link_path(request[0]);
@@ -1180,7 +1115,6 @@ CObject* File::DeleteLinkRequest(const CObjectArray& request) {
return CObject::IllegalArgumentError();
}
-
CObject* File::RenameLinkRequest(const CObjectArray& request) {
if ((request.Length() == 2) && request[0]->IsString() &&
request[1]->IsString()) {
@@ -1195,7 +1129,6 @@ CObject* File::RenameLinkRequest(const CObjectArray& request) {
return CObject::IllegalArgumentError();
}
-
CObject* File::LinkTargetRequest(const CObjectArray& request) {
if ((request.Length() == 1) && request[0]->IsString()) {
CObjectString link_path(request[0]);
@@ -1210,7 +1143,6 @@ CObject* File::LinkTargetRequest(const CObjectArray& request) {
return CObject::IllegalArgumentError();
}
-
CObject* File::TypeRequest(const CObjectArray& request) {
if ((request.Length() == 2) && request[0]->IsString() &&
request[1]->IsBool()) {
@@ -1222,7 +1154,6 @@ CObject* File::TypeRequest(const CObjectArray& request) {
return CObject::IllegalArgumentError();
}
-
CObject* File::IdenticalRequest(const CObjectArray& request) {
if ((request.Length() == 2) && request[0]->IsString() &&
request[1]->IsString()) {
@@ -1241,7 +1172,6 @@ CObject* File::IdenticalRequest(const CObjectArray& request) {
return CObject::IllegalArgumentError();
}
-
CObject* File::StatRequest(const CObjectArray& request) {
if ((request.Length() == 1) && request[0]->IsString()) {
int64_t data[File::kStatSize];
@@ -1262,7 +1192,6 @@ CObject* File::StatRequest(const CObjectArray& request) {
return CObject::IllegalArgumentError();
}
-
CObject* File::LockRequest(const CObjectArray& request) {
if ((request.Length() >= 1) && request[0]->IsIntptr()) {
File* file = CObjectToFilePointer(request[0]);
« no previous file with comments | « runtime/bin/fdutils_macos.cc ('k') | runtime/bin/file_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698