Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1236)

Unified Diff: runtime/bin/socket_fuchsia.cc

Issue 2974233002: VM: Re-format to use at most one newline between functions (Closed)
Patch Set: Rebase and merge Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/socket_base_win.cc ('k') | runtime/bin/socket_linux.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/socket_fuchsia.cc
diff --git a/runtime/bin/socket_fuchsia.cc b/runtime/bin/socket_fuchsia.cc
index f8c138fd4703cc5e5d00390cfead29e01a99de8d..097e6bd9a877076cb31a7e849b58aad85278e91b 100644
--- a/runtime/bin/socket_fuchsia.cc
+++ b/runtime/bin/socket_fuchsia.cc
@@ -9,7 +9,7 @@
#include "bin/socket.h"
-#include <errno.h> // NOLINT
+#include <errno.h> // NOLINT
#include "bin/eventhandler.h"
#include "bin/fdutils.h"
@@ -45,7 +45,6 @@ namespace bin {
Socket::Socket(intptr_t fd)
: ReferenceCounted(), fd_(fd), port_(ILLEGAL_PORT) {}
-
void Socket::SetClosedFd() {
ASSERT(fd_ != kClosedFd);
IOHandle* handle = reinterpret_cast<IOHandle*>(fd_);
@@ -54,7 +53,6 @@ void Socket::SetClosedFd() {
fd_ = kClosedFd;
}
-
static intptr_t Create(const RawAddr& addr) {
LOG_INFO("Create: calling socket(SOCK_STREAM)\n");
intptr_t fd = NO_RETRY_EXPECTED(socket(addr.ss.ss_family, SOCK_STREAM, 0));
@@ -72,7 +70,6 @@ static intptr_t Create(const RawAddr& addr) {
return reinterpret_cast<intptr_t>(io_handle);
}
-
static intptr_t Connect(intptr_t fd, const RawAddr& addr) {
IOHandle* handle = reinterpret_cast<IOHandle*>(fd);
LOG_INFO("Connect: calling connect(%ld)\n", handle->fd());
@@ -87,7 +84,6 @@ static intptr_t Connect(intptr_t fd, const RawAddr& addr) {
return -1;
}
-
intptr_t Socket::CreateConnect(const RawAddr& addr) {
intptr_t fd = Create(addr);
if (fd < 0) {
@@ -104,7 +100,6 @@ intptr_t Socket::CreateConnect(const RawAddr& addr) {
return Connect(fd, addr);
}
-
intptr_t Socket::CreateBindConnect(const RawAddr& addr,
const RawAddr& source_addr) {
LOG_ERR("SocketBase::CreateBindConnect is unimplemented\n");
@@ -112,14 +107,12 @@ intptr_t Socket::CreateBindConnect(const RawAddr& addr,
return -1;
}
-
intptr_t Socket::CreateBindDatagram(const RawAddr& addr, bool reuseAddress) {
LOG_ERR("SocketBase::CreateBindDatagram is unimplemented\n");
UNIMPLEMENTED();
return -1;
}
-
intptr_t ServerSocket::CreateBindListen(const RawAddr& addr,
intptr_t backlog,
bool v6_only) {
@@ -189,13 +182,11 @@ intptr_t ServerSocket::CreateBindListen(const RawAddr& addr,
return reinterpret_cast<intptr_t>(io_handle);
}
-
bool ServerSocket::StartAccept(intptr_t fd) {
USE(fd);
return true;
}
-
static bool IsTemporaryAcceptError(int error) {
// On Linux a number of protocol errors should be treated as EAGAIN.
// These are the ones for TCP/IP.
@@ -205,7 +196,6 @@ static bool IsTemporaryAcceptError(int error) {
(error == ENETUNREACH);
}
-
intptr_t ServerSocket::Accept(intptr_t fd) {
IOHandle* listen_handle = reinterpret_cast<IOHandle*>(fd);
intptr_t socket;
« no previous file with comments | « runtime/bin/socket_base_win.cc ('k') | runtime/bin/socket_linux.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698