Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Unified Diff: runtime/vm/timeline_test.cc

Issue 2974233002: VM: Re-format to use at most one newline between functions (Closed)
Patch Set: Rebase and merge Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/timeline_analysis.cc ('k') | runtime/vm/timer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/timeline_test.cc
diff --git a/runtime/vm/timeline_test.cc b/runtime/vm/timeline_test.cc
index aa2972facc19f498540fcce898fb71e4220b9816..1cec65b8e05ef13faf030edee5c0b2037d809013 100644
--- a/runtime/vm/timeline_test.cc
+++ b/runtime/vm/timeline_test.cc
@@ -30,7 +30,6 @@ class TimelineRecorderOverride : public ValueObject {
TimelineEventRecorder* recorder_;
};
-
class TimelineTestHelper : public AllStatic {
public:
static void SetStream(TimelineEvent* event, TimelineStream* stream) {
@@ -99,7 +98,6 @@ class TimelineTestHelper : public AllStatic {
static void FinishBlock(TimelineEventBlock* block) { block->Finish(); }
};
-
TEST_CASE(TimelineEventIsValid) {
// Create a test stream.
TimelineStream stream;
@@ -120,7 +118,6 @@ TEST_CASE(TimelineEventIsValid) {
EXPECT(!event.IsValid());
}
-
TEST_CASE(TimelineEventDuration) {
// Create a test stream.
TimelineStream stream;
@@ -137,7 +134,6 @@ TEST_CASE(TimelineEventDuration) {
EXPECT_GE(event.TimeDuration(), current_duration);
}
-
TEST_CASE(TimelineEventDurationPrintJSON) {
// Create a test stream.
TimelineStream stream;
@@ -165,7 +161,6 @@ TEST_CASE(TimelineEventDurationPrintJSON) {
event.DurationEnd();
}
-
TEST_CASE(TimelineEventPrintSystrace) {
const intptr_t kBufferLength = 1024;
char buffer[kBufferLength];
@@ -209,7 +204,6 @@ TEST_CASE(TimelineEventPrintSystrace) {
EXPECT_STREQ("", buffer);
}
-
TEST_CASE(TimelineEventArguments) {
// Create a test stream.
TimelineStream stream;
@@ -231,7 +225,6 @@ TEST_CASE(TimelineEventArguments) {
event.DurationEnd();
}
-
TEST_CASE(TimelineEventArgumentsPrintJSON) {
// Create a test stream.
TimelineStream stream;
@@ -258,7 +251,6 @@ TEST_CASE(TimelineEventArgumentsPrintJSON) {
}
}
-
TEST_CASE(TimelineEventBufferPrintJSON) {
TimelineEventRecorder* recorder = Timeline::recorder();
JSONStream js;
@@ -270,7 +262,6 @@ TEST_CASE(TimelineEventBufferPrintJSON) {
EXPECT_SUBSTRING("\"traceEvents\":[", js.ToCString());
}
-
// Count the number of each event type seen.
class EventCounterRecorder : public TimelineEventCallbackRecorder {
public:
@@ -288,7 +279,6 @@ class EventCounterRecorder : public TimelineEventCallbackRecorder {
intptr_t counts_[TimelineEvent::kNumEventTypes];
};
-
TEST_CASE(TimelineEventCallbackRecorderBasic) {
EventCounterRecorder* recorder = new EventCounterRecorder();
TimelineRecorderOverride override(recorder);
@@ -347,13 +337,11 @@ TEST_CASE(TimelineEventCallbackRecorderBasic) {
delete recorder;
}
-
static bool LabelMatch(TimelineEvent* event, const char* label) {
ASSERT(event != NULL);
return strcmp(event->label(), label) == 0;
}
-
TEST_CASE(TimelineAnalysis_ThreadBlockCount) {
TimelineEventEndlessRecorder* recorder = new TimelineEventEndlessRecorder();
ASSERT(recorder != NULL);
@@ -473,7 +461,6 @@ TEST_CASE(TimelineAnalysis_ThreadBlockCount) {
delete recorder;
}
-
TEST_CASE(TimelineRingRecorderJSONOrder) {
TimelineStream stream;
stream.Init("testStream", true);
@@ -512,7 +499,6 @@ TEST_CASE(TimelineRingRecorderJSONOrder) {
delete recorder;
}
-
TEST_CASE(TimelinePauses_Basic) {
TimelineEventEndlessRecorder* recorder = new TimelineEventEndlessRecorder();
ASSERT(recorder != NULL);
@@ -686,7 +672,6 @@ TEST_CASE(TimelinePauses_Basic) {
delete recorder;
}
-
TEST_CASE(TimelinePauses_BeginEnd) {
TimelineEventEndlessRecorder* recorder = new TimelineEventEndlessRecorder();
ASSERT(recorder != NULL);
« no previous file with comments | « runtime/vm/timeline_analysis.cc ('k') | runtime/vm/timer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698