Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Unified Diff: runtime/vm/dart_entry.cc

Issue 2974233002: VM: Re-format to use at most one newline between functions (Closed)
Patch Set: Rebase and merge Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart_entry.h ('k') | runtime/vm/dart_entry_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart_entry.cc
diff --git a/runtime/vm/dart_entry.cc b/runtime/vm/dart_entry.cc
index 97851a024eeeea02e1c3e85a408d9d2a5a75d4ef..880046533839020af52f698d5deacca0b02927ed 100644
--- a/runtime/vm/dart_entry.cc
+++ b/runtime/vm/dart_entry.cc
@@ -20,7 +20,6 @@ namespace dart {
// A cache of VM heap allocated arguments descriptors.
RawArray* ArgumentsDescriptor::cached_args_descriptors_[kCachedDescriptorCount];
-
RawObject* DartEntry::InvokeFunction(const Function& function,
const Array& arguments) {
ASSERT(Thread::Current()->IsMutatorThread());
@@ -30,7 +29,6 @@ RawObject* DartEntry::InvokeFunction(const Function& function,
return InvokeFunction(function, arguments, arguments_descriptor);
}
-
class ScopedIsolateStackLimits : public ValueObject {
public:
explicit ScopedIsolateStackLimits(Thread* thread, uword current_sp)
@@ -65,7 +63,6 @@ class ScopedIsolateStackLimits : public ValueObject {
uword saved_stack_limit_;
};
-
// Clears/restores Thread::long_jump_base on construction/destruction.
// Ensures that we do not attempt to long jump across Dart frames.
class SuspendLongJumpScope : public StackResource {
@@ -84,7 +81,6 @@ class SuspendLongJumpScope : public StackResource {
LongJumpScope* saved_long_jump_base_;
};
-
RawObject* DartEntry::InvokeFunction(const Function& function,
const Array& arguments,
const Array& arguments_descriptor,
@@ -132,7 +128,6 @@ RawObject* DartEntry::InvokeFunction(const Function& function,
#endif
}
-
RawObject* DartEntry::InvokeClosure(const Array& arguments) {
const int kTypeArgsLen = 0; // No support to pass type args to generic func.
const Array& arguments_descriptor =
@@ -140,7 +135,6 @@ RawObject* DartEntry::InvokeClosure(const Array& arguments) {
return InvokeClosure(arguments, arguments_descriptor);
}
-
RawObject* DartEntry::InvokeClosure(const Array& arguments,
const Array& arguments_descriptor) {
Thread* thread = Thread::Current();
@@ -215,7 +209,6 @@ RawObject* DartEntry::InvokeClosure(const Array& arguments,
arguments_descriptor);
}
-
RawObject* DartEntry::InvokeNoSuchMethod(const Instance& receiver,
const String& target_name,
const Array& arguments,
@@ -268,24 +261,20 @@ RawObject* DartEntry::InvokeNoSuchMethod(const Instance& receiver,
return InvokeFunction(function, args);
}
-
ArgumentsDescriptor::ArgumentsDescriptor(const Array& array) : array_(array) {}
intptr_t ArgumentsDescriptor::TypeArgsLen() const {
return Smi::Cast(Object::Handle(array_.At(kTypeArgsLenIndex))).Value();
}
-
intptr_t ArgumentsDescriptor::Count() const {
return Smi::Cast(Object::Handle(array_.At(kCountIndex))).Value();
}
-
intptr_t ArgumentsDescriptor::PositionalCount() const {
return Smi::Cast(Object::Handle(array_.At(kPositionalCountIndex))).Value();
}
-
RawString* ArgumentsDescriptor::NameAt(intptr_t index) const {
const intptr_t offset =
kFirstNamedEntryIndex + (index * kNamedEntrySize) + kNameOffset;
@@ -294,40 +283,33 @@ RawString* ArgumentsDescriptor::NameAt(intptr_t index) const {
return result.raw();
}
-
intptr_t ArgumentsDescriptor::PositionAt(intptr_t index) const {
const intptr_t offset =
kFirstNamedEntryIndex + (index * kNamedEntrySize) + kPositionOffset;
return Smi::Value(Smi::RawCast(array_.At(offset)));
}
-
bool ArgumentsDescriptor::MatchesNameAt(intptr_t index,
const String& other) const {
return NameAt(index) == other.raw();
}
-
intptr_t ArgumentsDescriptor::type_args_len_offset() {
return Array::element_offset(kTypeArgsLenIndex);
}
-
intptr_t ArgumentsDescriptor::count_offset() {
return Array::element_offset(kCountIndex);
}
-
intptr_t ArgumentsDescriptor::positional_count_offset() {
return Array::element_offset(kPositionalCountIndex);
}
-
intptr_t ArgumentsDescriptor::first_named_entry_offset() {
return Array::element_offset(kFirstNamedEntryIndex);
}
-
RawArray* ArgumentsDescriptor::New(intptr_t type_args_len,
intptr_t num_arguments,
const Array& optional_arguments_names) {
@@ -392,7 +374,6 @@ RawArray* ArgumentsDescriptor::New(intptr_t type_args_len,
return descriptor.raw();
}
-
RawArray* ArgumentsDescriptor::New(intptr_t type_args_len,
intptr_t num_arguments) {
ASSERT(type_args_len >= 0);
@@ -403,7 +384,6 @@ RawArray* ArgumentsDescriptor::New(intptr_t type_args_len,
return NewNonCached(type_args_len, num_arguments);
}
-
RawArray* ArgumentsDescriptor::NewNonCached(intptr_t type_args_len,
intptr_t num_arguments,
bool canonicalize) {
@@ -439,7 +419,6 @@ RawArray* ArgumentsDescriptor::NewNonCached(intptr_t type_args_len,
return descriptor.raw();
}
-
void ArgumentsDescriptor::InitOnce() {
for (int i = 0; i < kCachedDescriptorCount; i++) {
cached_args_descriptors_[i] =
@@ -447,7 +426,6 @@ void ArgumentsDescriptor::InitOnce() {
}
}
-
RawObject* DartLibraryCalls::InstanceCreate(const Library& lib,
const String& class_name,
const String& constructor_name,
@@ -480,7 +458,6 @@ RawObject* DartLibraryCalls::InstanceCreate(const Library& lib,
return exception_object.raw();
}
-
RawObject* DartLibraryCalls::ToString(const Instance& receiver) {
const int kTypeArgsLen = 0;
const int kNumArguments = 1; // Receiver.
@@ -497,7 +474,6 @@ RawObject* DartLibraryCalls::ToString(const Instance& receiver) {
return result.raw();
}
-
RawObject* DartLibraryCalls::HashCode(const Instance& receiver) {
const int kTypeArgsLen = 0;
const int kNumArguments = 1; // Receiver.
@@ -514,7 +490,6 @@ RawObject* DartLibraryCalls::HashCode(const Instance& receiver) {
return result.raw();
}
-
RawObject* DartLibraryCalls::Equals(const Instance& left,
const Instance& right) {
const int kTypeArgsLen = 0;
@@ -534,7 +509,6 @@ RawObject* DartLibraryCalls::Equals(const Instance& left,
return result.raw();
}
-
RawObject* DartLibraryCalls::LookupHandler(Dart_Port port_id) {
Thread* thread = Thread::Current();
Zone* zone = thread->zone();
@@ -562,7 +536,6 @@ RawObject* DartLibraryCalls::LookupHandler(Dart_Port port_id) {
return result.raw();
}
-
RawObject* DartLibraryCalls::HandleMessage(const Object& handler,
const Instance& message) {
Thread* thread = Thread::Current();
@@ -600,7 +573,6 @@ RawObject* DartLibraryCalls::HandleMessage(const Object& handler,
return result.raw();
}
-
RawObject* DartLibraryCalls::DrainMicrotaskQueue() {
Zone* zone = Thread::Current()->zone();
Library& isolate_lib = Library::Handle(zone, Library::IsolateLibrary());
@@ -614,7 +586,6 @@ RawObject* DartLibraryCalls::DrainMicrotaskQueue() {
return result.raw();
}
-
RawObject* DartLibraryCalls::MapSetAt(const Instance& map,
const Instance& key,
const Instance& value) {
« no previous file with comments | « runtime/vm/dart_entry.h ('k') | runtime/vm/dart_entry_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698