Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: runtime/bin/dfe.cc

Issue 2974233002: VM: Re-format to use at most one newline between functions (Closed)
Patch Set: Rebase and merge Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/dartutils.cc ('k') | runtime/bin/directory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/dfe.cc
diff --git a/runtime/bin/dfe.cc b/runtime/bin/dfe.cc
index 8ad055df505d6864cb81ce3427fa97dfa3d14c3d..a5fb69012a6c0746ab29f645d4e584281f1dfd1f 100644
--- a/runtime/bin/dfe.cc
+++ b/runtime/bin/dfe.cc
@@ -15,7 +15,6 @@ namespace bin {
const char kPlatformBinaryName[] = "platform.dill";
const char kVMServiceIOBinaryName[] = "vmservice_io.dill";
-
DFE::DFE()
: frontend_filename_(NULL),
platform_binary_filename_(NULL),
@@ -23,7 +22,6 @@ DFE::DFE()
kernel_platform_(NULL),
kernel_vmservice_io_(NULL) {}
-
DFE::~DFE() {
frontend_filename_ = NULL;
@@ -43,7 +41,6 @@ DFE::~DFE() {
}
}
-
void DFE::SetKernelBinaries(const char* name) {
intptr_t len = snprintf(NULL, 0, "%s%s%s", name, File::PathSeparator(),
kPlatformBinaryName) +
@@ -60,7 +57,6 @@ void DFE::SetKernelBinaries(const char* name) {
File::PathSeparator(), kVMServiceIOBinaryName);
}
-
Dart_Handle DFE::ReloadScript(Dart_Isolate isolate, const char* url_string) {
ASSERT(!Dart_IsServiceIsolate(isolate) && !Dart_IsKernelIsolate(isolate));
// First check if the URL points to a Kernel IR file in which case we
@@ -94,7 +90,6 @@ Dart_Handle DFE::ReloadScript(Dart_Isolate isolate, const char* url_string) {
return Dart_Null();
}
-
void* DFE::CompileAndReadScript(const char* script_uri,
char** error,
int* exit_code) {
@@ -118,17 +113,14 @@ void* DFE::CompileAndReadScript(const char* script_uri,
return NULL;
}
-
void* DFE::ReadPlatform() {
return kernel_platform_ = ReadScript(platform_binary_filename_);
}
-
void* DFE::ReadVMServiceIO() {
return kernel_vmservice_io_ = ReadScript(vmservice_io_binary_filename_);
}
-
void* DFE::ReadScript(const char* script_uri) {
const uint8_t* buffer = NULL;
intptr_t buffer_length = -1;
@@ -139,7 +131,6 @@ void* DFE::ReadScript(const char* script_uri) {
return NULL;
}
-
bool DFE::TryReadKernelFile(const char* script_uri,
const uint8_t** kernel_ir,
intptr_t* kernel_ir_size) {
@@ -173,6 +164,5 @@ bool DFE::TryReadKernelFile(const char* script_uri,
return false;
}
-
} // namespace bin
} // namespace dart
« no previous file with comments | « runtime/bin/dartutils.cc ('k') | runtime/bin/directory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698