Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(925)

Unified Diff: runtime/vm/timeline.h

Issue 2974233002: VM: Re-format to use at most one newline between functions (Closed)
Patch Set: Rebase and merge Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/thread_test.cc ('k') | runtime/vm/timeline.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/timeline.h
diff --git a/runtime/vm/timeline.h b/runtime/vm/timeline.h
index 0abf0254d91b0cdca4c8dda9dccb7fbfae28cc9a..0cf477cc98dd0c1a720d51278768ead98760e317 100644
--- a/runtime/vm/timeline.h
+++ b/runtime/vm/timeline.h
@@ -137,13 +137,11 @@ class Timeline : public AllStatic {
friend class ReclaimBlocksIsolateVisitor;
};
-
struct TimelineEventArgument {
const char* name;
char* value;
};
-
// You should get a |TimelineEvent| from a |TimelineStream|.
class TimelineEvent {
public:
@@ -396,7 +394,6 @@ class TimelineEvent {
DISALLOW_COPY_AND_ASSIGN(TimelineEvent);
};
-
#ifndef PRODUCT
#define TIMELINE_FUNCTION_COMPILATION_DURATION(thread, name, function) \
TimelineDurationScope tds(thread, Timeline::GetCompilerStream(), name); \
@@ -461,7 +458,6 @@ class TimelineEventScope : public StackResource {
DISALLOW_COPY_AND_ASSIGN(TimelineEventScope);
};
-
class TimelineDurationScope : public TimelineEventScope {
public:
TimelineDurationScope(TimelineStream* stream, const char* label);
@@ -479,7 +475,6 @@ class TimelineDurationScope : public TimelineEventScope {
DISALLOW_COPY_AND_ASSIGN(TimelineDurationScope);
};
-
class TimelineBeginEndScope : public TimelineEventScope {
public:
TimelineBeginEndScope(TimelineStream* stream, const char* label);
@@ -497,7 +492,6 @@ class TimelineBeginEndScope : public TimelineEventScope {
DISALLOW_COPY_AND_ASSIGN(TimelineBeginEndScope);
};
-
// A block of |TimelineEvent|s. Not thread safe.
class TimelineEventBlock {
public:
@@ -577,7 +571,6 @@ class TimelineEventBlock {
DISALLOW_COPY_AND_ASSIGN(TimelineEventBlock);
};
-
class TimelineEventFilter : public ValueObject {
public:
TimelineEventFilter(int64_t time_origin_micros = -1,
@@ -609,7 +602,6 @@ class TimelineEventFilter : public ValueObject {
int64_t time_extent_micros_;
};
-
class IsolateTimelineEventFilter : public TimelineEventFilter {
public:
explicit IsolateTimelineEventFilter(Dart_Port isolate_id,
@@ -632,7 +624,6 @@ class IsolateTimelineEventFilter : public TimelineEventFilter {
Dart_Port isolate_id_;
};
-
// Recorder of |TimelineEvent|s.
class TimelineEventRecorder {
public:
@@ -684,7 +675,6 @@ class TimelineEventRecorder {
DISALLOW_COPY_AND_ASSIGN(TimelineEventRecorder);
};
-
// An abstract recorder that stores events in a buffer of fixed capacity.
class TimelineEventFixedBufferRecorder : public TimelineEventRecorder {
public:
@@ -711,7 +701,6 @@ class TimelineEventFixedBufferRecorder : public TimelineEventRecorder {
intptr_t block_cursor_;
};
-
// A recorder that stores events in a buffer of fixed capacity. When the buffer
// is full, new events overwrite old events.
class TimelineEventRingRecorder : public TimelineEventFixedBufferRecorder {
@@ -726,7 +715,6 @@ class TimelineEventRingRecorder : public TimelineEventFixedBufferRecorder {
TimelineEventBlock* GetNewBlockLocked();
};
-
// A recorder that writes events to Android Systrace. Events are also stored in
// a buffer of fixed capacity. When the buffer is full, new events overwrite
// old events.
@@ -744,7 +732,6 @@ class TimelineEventSystraceRecorder : public TimelineEventFixedBufferRecorder {
int systrace_fd_;
};
-
#if defined(HOST_OS_FUCHSIA)
// A recorder that sends events to Fuchsia's tracing app. Events are also stored
// in a buffer of fixed capacity. When the buffer is full, new events overwrite
@@ -763,7 +750,6 @@ class TimelineEventFuchsiaRecorder : public TimelineEventFixedBufferRecorder {
};
#endif // defined(HOST_OS_FUCHSIA)
-
// A recorder that stores events in a buffer of fixed capacity. When the buffer
// is full, new events are dropped.
class TimelineEventStartupRecorder : public TimelineEventFixedBufferRecorder {
@@ -778,7 +764,6 @@ class TimelineEventStartupRecorder : public TimelineEventFixedBufferRecorder {
TimelineEventBlock* GetNewBlockLocked();
};
-
// An abstract recorder that calls |OnEvent| whenever an event is complete.
// This should only be used for testing.
class TimelineEventCallbackRecorder : public TimelineEventRecorder {
@@ -803,7 +788,6 @@ class TimelineEventCallbackRecorder : public TimelineEventRecorder {
void CompleteEvent(TimelineEvent* event);
};
-
// A recorder that stores events in chains of blocks of events.
// NOTE: This recorder will continue to allocate blocks until it exhausts
// memory.
@@ -832,7 +816,6 @@ class TimelineEventEndlessRecorder : public TimelineEventRecorder {
friend class TimelineTestHelper;
};
-
// An iterator for blocks.
class TimelineEventBlockIterator {
public:
@@ -852,7 +835,6 @@ class TimelineEventBlockIterator {
TimelineEventRecorder* recorder_;
};
-
} // namespace dart
#endif // RUNTIME_VM_TIMELINE_H_
« no previous file with comments | « runtime/vm/thread_test.cc ('k') | runtime/vm/timeline.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698