Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Unified Diff: runtime/vm/locations.cc

Issue 2974233002: VM: Re-format to use at most one newline between functions (Closed)
Patch Set: Rebase and merge Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/locations.h ('k') | runtime/vm/lockers.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/locations.cc
diff --git a/runtime/vm/locations.cc b/runtime/vm/locations.cc
index 51758199d4c0854a57b26d3e661a9b857561fbf4..22480dd109f3dd84881026cf3fd46375a47e8116 100644
--- a/runtime/vm/locations.cc
+++ b/runtime/vm/locations.cc
@@ -21,7 +21,6 @@ intptr_t RegisterSet::RegisterCount(intptr_t registers) {
return count;
}
-
LocationSummary::LocationSummary(Zone* zone,
intptr_t input_count,
intptr_t temp_count,
@@ -38,7 +37,6 @@ LocationSummary::LocationSummary(Zone* zone,
temp_locations_ = zone->Alloc<Location>(num_temps_);
}
-
LocationSummary* LocationSummary::Make(
Zone* zone,
intptr_t input_count,
@@ -53,7 +51,6 @@ LocationSummary* LocationSummary::Make(
return summary;
}
-
Location Location::Pair(Location first, Location second) {
PairLocation* pair_location = new PairLocation();
ASSERT((reinterpret_cast<intptr_t>(pair_location) & kLocationTagMask) == 0);
@@ -63,13 +60,11 @@ Location Location::Pair(Location first, Location second) {
return loc;
}
-
PairLocation* Location::AsPairLocation() const {
ASSERT(IsPairLocation());
return reinterpret_cast<PairLocation*>(value_ & ~kLocationTagMask);
}
-
Location Location::RegisterOrConstant(Value* value) {
ConstantInstr* constant = value->definition()->AsConstant();
return ((constant != NULL) && Assembler::IsSafe(constant->value()))
@@ -77,7 +72,6 @@ Location Location::RegisterOrConstant(Value* value) {
: Location::RequiresRegister();
}
-
Location Location::RegisterOrSmiConstant(Value* value) {
ConstantInstr* constant = value->definition()->AsConstant();
return ((constant != NULL) && Assembler::IsSafeSmi(constant->value()))
@@ -85,7 +79,6 @@ Location Location::RegisterOrSmiConstant(Value* value) {
: Location::RequiresRegister();
}
-
Location Location::WritableRegisterOrSmiConstant(Value* value) {
ConstantInstr* constant = value->definition()->AsConstant();
return ((constant != NULL) && Assembler::IsSafeSmi(constant->value()))
@@ -93,7 +86,6 @@ Location Location::WritableRegisterOrSmiConstant(Value* value) {
: Location::WritableRegister();
}
-
Location Location::FixedRegisterOrConstant(Value* value, Register reg) {
ConstantInstr* constant = value->definition()->AsConstant();
return ((constant != NULL) && Assembler::IsSafe(constant->value()))
@@ -101,7 +93,6 @@ Location Location::FixedRegisterOrConstant(Value* value, Register reg) {
: Location::RegisterLocation(reg);
}
-
Location Location::FixedRegisterOrSmiConstant(Value* value, Register reg) {
ConstantInstr* constant = value->definition()->AsConstant();
return ((constant != NULL) && Assembler::IsSafeSmi(constant->value()))
@@ -109,7 +100,6 @@ Location Location::FixedRegisterOrSmiConstant(Value* value, Register reg) {
: Location::RegisterLocation(reg);
}
-
Location Location::AnyOrConstant(Value* value) {
ConstantInstr* constant = value->definition()->AsConstant();
return ((constant != NULL) && Assembler::IsSafe(constant->value()))
@@ -117,7 +107,6 @@ Location Location::AnyOrConstant(Value* value) {
: Location::Any();
}
-
// DBC does not have an notion of 'address' in its instruction set.
#if !defined(TARGET_ARCH_DBC)
Address Location::ToStackSlotAddress() const {
@@ -154,12 +143,10 @@ intptr_t Location::ToStackSlotOffset() const {
}
}
-
const Object& Location::constant() const {
return constant_instruction()->value();
}
-
const char* Location::Name() const {
switch (kind()) {
case kInvalid:
@@ -201,7 +188,6 @@ const char* Location::Name() const {
return "?";
}
-
void Location::PrintTo(BufferFormatter* f) const {
if (!FLAG_support_il_printer) {
return;
@@ -223,7 +209,6 @@ void Location::PrintTo(BufferFormatter* f) const {
}
}
-
const char* Location::ToCString() const {
char buffer[1024];
BufferFormatter bf(buffer, 1024);
@@ -231,7 +216,6 @@ const char* Location::ToCString() const {
return Thread::Current()->zone()->MakeCopyOfString(buffer);
}
-
void Location::Print() const {
if (kind() == kStackSlot) {
THR_Print("S%+" Pd "", stack_index());
@@ -240,7 +224,6 @@ void Location::Print() const {
}
}
-
Location Location::Copy() const {
if (IsPairLocation()) {
PairLocation* pair = AsPairLocation();
@@ -253,7 +236,6 @@ Location Location::Copy() const {
}
}
-
Location Location::RemapForSlowPath(Definition* def,
intptr_t* cpu_reg_slots,
intptr_t* fpu_reg_slots) const {
@@ -306,7 +288,6 @@ Location Location::RemapForSlowPath(Definition* def,
return *this;
}
-
void LocationSummary::PrintTo(BufferFormatter* f) const {
if (!FLAG_support_il_printer) {
return;
@@ -337,7 +318,6 @@ void LocationSummary::PrintTo(BufferFormatter* f) const {
if (always_calls()) f->Print(" C");
}
-
#if defined(DEBUG)
void LocationSummary::DiscoverWritableInputs() {
if (!HasCallOnSlowPath()) {
@@ -352,7 +332,6 @@ void LocationSummary::DiscoverWritableInputs() {
}
}
-
void LocationSummary::CheckWritableInputs() {
ASSERT(HasCallOnSlowPath());
for (intptr_t i = 0; i < input_count(); i++) {
« no previous file with comments | « runtime/vm/locations.h ('k') | runtime/vm/lockers.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698