Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Unified Diff: runtime/vm/code_patcher_ia32.cc

Issue 2974233002: VM: Re-format to use at most one newline between functions (Closed)
Patch Set: Rebase and merge Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/code_patcher_dbc.cc ('k') | runtime/vm/code_patcher_ia32_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/code_patcher_ia32.cc
diff --git a/runtime/vm/code_patcher_ia32.cc b/runtime/vm/code_patcher_ia32.cc
index d0b0a3e5e4353dfed5fa011ac804e021ac2c5a49..f408644f2f14cfdb7f5361d014736dc103f24591 100644
--- a/runtime/vm/code_patcher_ia32.cc
+++ b/runtime/vm/code_patcher_ia32.cc
@@ -55,7 +55,6 @@ class UnoptimizedCall : public ValueObject {
DISALLOW_IMPLICIT_CONSTRUCTORS(UnoptimizedCall);
};
-
class NativeCall : public UnoptimizedCall {
public:
explicit NativeCall(uword return_address) : UnoptimizedCall(return_address) {}
@@ -73,7 +72,6 @@ class NativeCall : public UnoptimizedCall {
DISALLOW_IMPLICIT_CONSTRUCTORS(NativeCall);
};
-
class InstanceCall : public UnoptimizedCall {
public:
explicit InstanceCall(uword return_address)
@@ -89,7 +87,6 @@ class InstanceCall : public UnoptimizedCall {
DISALLOW_IMPLICIT_CONSTRUCTORS(InstanceCall);
};
-
class UnoptimizedStaticCall : public UnoptimizedCall {
public:
explicit UnoptimizedStaticCall(uword return_address)
@@ -105,7 +102,6 @@ class UnoptimizedStaticCall : public UnoptimizedCall {
DISALLOW_IMPLICIT_CONSTRUCTORS(UnoptimizedStaticCall);
};
-
// The expected pattern of a dart static call:
// mov EDX, arguments_descriptor_array (optional in polymorphic calls)
// mov EDI, Immediate(code_object)
@@ -150,7 +146,6 @@ class StaticCall : public ValueObject {
DISALLOW_IMPLICIT_CONSTRUCTORS(StaticCall);
};
-
RawCode* CodePatcher::GetStaticCallTargetAt(uword return_address,
const Code& code) {
ASSERT(code.ContainsInstructionAt(return_address));
@@ -158,7 +153,6 @@ RawCode* CodePatcher::GetStaticCallTargetAt(uword return_address,
return call.target();
}
-
void CodePatcher::PatchStaticCallAt(uword return_address,
const Code& code,
const Code& new_target) {
@@ -169,12 +163,10 @@ void CodePatcher::PatchStaticCallAt(uword return_address,
call.set_target(new_target);
}
-
void CodePatcher::InsertDeoptimizationCallAt(uword start) {
UNREACHABLE();
}
-
RawCode* CodePatcher::GetInstanceCallAt(uword return_address,
const Code& code,
ICData* ic_data) {
@@ -186,7 +178,6 @@ RawCode* CodePatcher::GetInstanceCallAt(uword return_address,
return Code::null();
}
-
RawFunction* CodePatcher::GetUnoptimizedStaticCallAt(uword return_address,
const Code& code,
ICData* ic_data_result) {
@@ -200,7 +191,6 @@ RawFunction* CodePatcher::GetUnoptimizedStaticCallAt(uword return_address,
return ic_data.GetTargetAt(0);
}
-
void CodePatcher::PatchSwitchableCallAt(uword return_address,
const Code& caller_code,
const Object& data,
@@ -209,7 +199,6 @@ void CodePatcher::PatchSwitchableCallAt(uword return_address,
UNREACHABLE();
}
-
RawCode* CodePatcher::GetSwitchableCallTargetAt(uword return_address,
const Code& caller_code) {
// Switchable instance calls only generated for precompilation.
@@ -217,7 +206,6 @@ RawCode* CodePatcher::GetSwitchableCallTargetAt(uword return_address,
return Code::null();
}
-
RawObject* CodePatcher::GetSwitchableCallDataAt(uword return_address,
const Code& caller_code) {
// Switchable instance calls only generated for precompilation.
@@ -225,7 +213,6 @@ RawObject* CodePatcher::GetSwitchableCallDataAt(uword return_address,
return Object::null();
}
-
void CodePatcher::PatchNativeCallAt(uword return_address,
const Code& code,
NativeFunction target,
@@ -233,7 +220,6 @@ void CodePatcher::PatchNativeCallAt(uword return_address,
UNREACHABLE();
}
-
RawCode* CodePatcher::GetNativeCallAt(uword return_address,
const Code& code,
NativeFunction* target) {
@@ -241,7 +227,6 @@ RawCode* CodePatcher::GetNativeCallAt(uword return_address,
return NULL;
}
-
intptr_t CodePatcher::InstanceCallSizeInBytes() {
return InstanceCall::kPatternSize;
}
« no previous file with comments | « runtime/vm/code_patcher_dbc.cc ('k') | runtime/vm/code_patcher_ia32_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698