Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: runtime/vm/stack_frame.h

Issue 2974233002: VM: Re-format to use at most one newline between functions (Closed)
Patch Set: Rebase and merge Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/source_report_test.cc ('k') | runtime/vm/stack_frame.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/stack_frame.h
diff --git a/runtime/vm/stack_frame.h b/runtime/vm/stack_frame.h
index 97373766b34ab61674ce3ead0b55eb6a8eefe2f1..0d7d602b462b8f47f4f7890ab0987659aad46527 100644
--- a/runtime/vm/stack_frame.h
+++ b/runtime/vm/stack_frame.h
@@ -29,7 +29,6 @@ namespace dart {
class ObjectPointerVisitor;
class RawContext;
-
// Generic stack frame.
class StackFrame : public ValueObject {
public:
@@ -150,7 +149,6 @@ class StackFrame : public ValueObject {
DISALLOW_COPY_AND_ASSIGN(StackFrame);
};
-
// Exit frame is used to mark the transition from dart code into dart VM
// runtime code.
class ExitFrame : public StackFrame {
@@ -173,7 +171,6 @@ class ExitFrame : public StackFrame {
DISALLOW_COPY_AND_ASSIGN(ExitFrame);
};
-
// Entry Frame is used to mark the transition from dart VM runtime code into
// dart code.
class EntryFrame : public StackFrame {
@@ -196,7 +193,6 @@ class EntryFrame : public StackFrame {
DISALLOW_COPY_AND_ASSIGN(EntryFrame);
};
-
// A StackFrameIterator can be initialized with a thread other than the
// current thread. Because this is generally a bad idea, it is only allowed on
// Windows- where it is needed for the profiler. It is the responsibility of
@@ -299,7 +295,6 @@ class StackFrameIterator : public ValueObject {
DISALLOW_COPY_AND_ASSIGN(StackFrameIterator);
};
-
// Iterator for iterating over all dart frames (skips over exit frames,
// entry frames and stub frames).
// A DartFrameIterator can be initialized with an isolate other than the
@@ -353,7 +348,6 @@ class DartFrameIterator : public ValueObject {
DISALLOW_COPY_AND_ASSIGN(DartFrameIterator);
};
-
// Iterator for iterating over all inlined dart functions in an optimized
// dart frame (the iteration includes the function that is inlining the
// other functions).
@@ -396,24 +390,20 @@ class InlinedFunctionsIterator : public ValueObject {
DISALLOW_COPY_AND_ASSIGN(InlinedFunctionsIterator);
};
-
#if defined(DEBUG)
void ValidateFrames();
#endif
-
#if !defined(TARGET_ARCH_DBC)
DART_FORCE_INLINE static intptr_t LocalVarIndex(intptr_t fp_offset,
intptr_t var_index) {
return fp_offset + var_index;
}
-
DART_FORCE_INLINE static uword ParamAddress(uword fp, intptr_t reverse_index) {
return fp + (kParamEndSlotFromFp * kWordSize) + (reverse_index * kWordSize);
}
-
DART_FORCE_INLINE static bool IsCalleeFrameOf(uword fp, uword other_fp) {
return other_fp < fp;
}
@@ -424,12 +414,10 @@ DART_FORCE_INLINE static bool IsCalleeFrameOf(uword fp, uword other_fp) {
static const uword kInterruptStackLimit = ~static_cast<uword>(0);
#endif
-
DART_FORCE_INLINE static uword LocalVarAddress(uword fp, intptr_t index) {
return fp + LocalVarIndex(0, index) * kWordSize;
}
-
} // namespace dart
#endif // RUNTIME_VM_STACK_FRAME_H_
« no previous file with comments | « runtime/vm/source_report_test.cc ('k') | runtime/vm/stack_frame.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698