Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Unified Diff: runtime/lib/typed_data.cc

Issue 2974233002: VM: Re-format to use at most one newline between functions (Closed)
Patch Set: Rebase and merge Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/timeline.cc ('k') | runtime/lib/vmservice.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/typed_data.cc
diff --git a/runtime/lib/typed_data.cc b/runtime/lib/typed_data.cc
index 986c0357ae1be17a50484f9faa6df2d898a16e2e..9eec929f3475a5509ad50874794217586ecf9c1d 100644
--- a/runtime/lib/typed_data.cc
+++ b/runtime/lib/typed_data.cc
@@ -28,7 +28,6 @@ static void RangeCheck(intptr_t offset_in_bytes,
}
}
-
// Checks to see if a length will not result in an OOM error.
static void LengthCheck(intptr_t len, intptr_t max) {
if (len < 0 || len > max) {
@@ -38,7 +37,6 @@ static void LengthCheck(intptr_t len, intptr_t max) {
}
}
-
DEFINE_NATIVE_ENTRY(TypedData_length, 1) {
GET_NON_NULL_NATIVE_ARGUMENT(Instance, instance, arguments->NativeArgAt(0));
if (instance.IsTypedData()) {
@@ -55,7 +53,6 @@ DEFINE_NATIVE_ENTRY(TypedData_length, 1) {
return Integer::null();
}
-
template <typename DstType, typename SrcType>
static RawBool* CopyData(const Instance& dst,
const Instance& src,
@@ -83,7 +80,6 @@ static RawBool* CopyData(const Instance& dst,
return Bool::True().raw();
}
-
static bool IsClamped(intptr_t cid) {
switch (cid) {
case kTypedDataUint8ClampedArrayCid:
@@ -95,7 +91,6 @@ static bool IsClamped(intptr_t cid) {
}
}
-
static bool IsUint8(intptr_t cid) {
switch (cid) {
case kTypedDataUint8ClampedArrayCid:
@@ -110,7 +105,6 @@ static bool IsUint8(intptr_t cid) {
}
}
-
DEFINE_NATIVE_ENTRY(TypedData_setRange, 7) {
const Instance& dst = Instance::CheckedHandle(arguments->NativeArgAt(0));
const Smi& dst_start = Smi::CheckedHandle(arguments->NativeArgAt(1));
@@ -150,7 +144,6 @@ DEFINE_NATIVE_ENTRY(TypedData_setRange, 7) {
return Bool::False().raw();
}
-
// We check the length parameter against a possible maximum length for the
// array based on available physical addressable memory on the system. The
// maximum possible length is a scaled value of kSmiMax which is set up based
@@ -166,10 +159,8 @@ DEFINE_NATIVE_ENTRY(TypedData_setRange, 7) {
return TypedData::New(cid, len); \
}
-
#define TYPED_DATA_NEW_NATIVE(name) TYPED_DATA_NEW(name)
-
CLASS_LIST_TYPED_DATA(TYPED_DATA_NEW_NATIVE)
#define TYPED_DATA_GETTER(getter, object, ctor, access_size) \
@@ -196,7 +187,6 @@ CLASS_LIST_TYPED_DATA(TYPED_DATA_NEW_NATIVE)
return object::null(); \
}
-
#define TYPED_DATA_SETTER(setter, object, get_object_value, access_size, \
access_type) \
DEFINE_NATIVE_ENTRY(TypedData_##setter, 3) { \
@@ -250,7 +240,6 @@ TYPED_DATA_NATIVES(Float32x4, Float32x4, New, value, 16, simd128_value_t)
TYPED_DATA_NATIVES(Int32x4, Int32x4, New, value, 16, simd128_value_t)
TYPED_DATA_NATIVES(Float64x2, Float64x2, New, value, 16, simd128_value_t)
-
DEFINE_NATIVE_ENTRY(ByteData_ToEndianInt16, 2) {
GET_NON_NULL_NATIVE_ARGUMENT(Smi, host_value, arguments->NativeArgAt(0));
GET_NON_NULL_NATIVE_ARGUMENT(Bool, little_endian, arguments->NativeArgAt(1));
@@ -263,7 +252,6 @@ DEFINE_NATIVE_ENTRY(ByteData_ToEndianInt16, 2) {
return Smi::New(value);
}
-
DEFINE_NATIVE_ENTRY(ByteData_ToEndianUint16, 2) {
GET_NON_NULL_NATIVE_ARGUMENT(Smi, host_value, arguments->NativeArgAt(0));
GET_NON_NULL_NATIVE_ARGUMENT(Bool, little_endian, arguments->NativeArgAt(1));
@@ -274,7 +262,6 @@ DEFINE_NATIVE_ENTRY(ByteData_ToEndianUint16, 2) {
return Smi::New(Utils::HostToBigEndian16(value));
}
-
DEFINE_NATIVE_ENTRY(ByteData_ToEndianInt32, 2) {
GET_NON_NULL_NATIVE_ARGUMENT(Integer, host_value, arguments->NativeArgAt(0));
GET_NON_NULL_NATIVE_ARGUMENT(Bool, little_endian, arguments->NativeArgAt(1));
@@ -289,7 +276,6 @@ DEFINE_NATIVE_ENTRY(ByteData_ToEndianInt32, 2) {
return Integer::New(value);
}
-
DEFINE_NATIVE_ENTRY(ByteData_ToEndianUint32, 2) {
GET_NON_NULL_NATIVE_ARGUMENT(Integer, host_value, arguments->NativeArgAt(0));
GET_NON_NULL_NATIVE_ARGUMENT(Bool, little_endian, arguments->NativeArgAt(1));
@@ -303,7 +289,6 @@ DEFINE_NATIVE_ENTRY(ByteData_ToEndianUint32, 2) {
return Integer::New(value);
}
-
DEFINE_NATIVE_ENTRY(ByteData_ToEndianInt64, 2) {
GET_NON_NULL_NATIVE_ARGUMENT(Integer, host_value, arguments->NativeArgAt(0));
GET_NON_NULL_NATIVE_ARGUMENT(Bool, little_endian, arguments->NativeArgAt(1));
@@ -316,7 +301,6 @@ DEFINE_NATIVE_ENTRY(ByteData_ToEndianInt64, 2) {
return Integer::New(value);
}
-
DEFINE_NATIVE_ENTRY(ByteData_ToEndianUint64, 2) {
GET_NON_NULL_NATIVE_ARGUMENT(Integer, host_value, arguments->NativeArgAt(0));
GET_NON_NULL_NATIVE_ARGUMENT(Bool, little_endian, arguments->NativeArgAt(1));
@@ -337,7 +321,6 @@ DEFINE_NATIVE_ENTRY(ByteData_ToEndianUint64, 2) {
return Integer::NewFromUint64(value);
}
-
DEFINE_NATIVE_ENTRY(ByteData_ToEndianFloat32, 2) {
GET_NON_NULL_NATIVE_ARGUMENT(Double, host_value, arguments->NativeArgAt(0));
GET_NON_NULL_NATIVE_ARGUMENT(Bool, little_endian, arguments->NativeArgAt(1));
@@ -352,7 +335,6 @@ DEFINE_NATIVE_ENTRY(ByteData_ToEndianFloat32, 2) {
return Double::New(value);
}
-
DEFINE_NATIVE_ENTRY(ByteData_ToEndianFloat64, 2) {
GET_NON_NULL_NATIVE_ARGUMENT(Double, host_value, arguments->NativeArgAt(0));
GET_NON_NULL_NATIVE_ARGUMENT(Bool, little_endian, arguments->NativeArgAt(1));
« no previous file with comments | « runtime/lib/timeline.cc ('k') | runtime/lib/vmservice.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698