runtime/vm/code_patcher_arm64_test.cc - Issue 2974233002: VM: Re-format to use at most one newline between functions

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: runtime/vm/code_patcher_arm64_test.cc

Issue 2974233002: VM: Re-format to use at most one newline between functions (Closed)

Patch Set: Rebase and merge Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « runtime/vm/code_patcher_arm64.cc ('k') | runtime/vm/code_patcher_arm_test.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file	1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file

2 // for details. All rights reserved. Use of this source code is governed by a	2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.	3 // BSD-style license that can be found in the LICENSE file.

4	4

5 #include "vm/globals.h"	5 #include "vm/globals.h"

6 #if defined(TARGET_ARCH_ARM64)	6 #if defined(TARGET_ARCH_ARM64)

7	7

8 #include "vm/assembler.h"	8 #include "vm/assembler.h"

9 #include "vm/code_patcher.h"	9 #include "vm/code_patcher.h"

10 #include "vm/dart_entry.h"	10 #include "vm/dart_entry.h"

(...skipping 30 matching lines...) Expand all Loading...
41 ICData::New(function, target_name, args_descriptor, 15, 1, false));	41 ICData::New(function, target_name, args_descriptor, 15, 1, false));

42	42

43 // Code accessing pp is generated, but not executed. Uninitialized pp is OK.	43 // Code accessing pp is generated, but not executed. Uninitialized pp is OK.

44 __ set_constant_pool_allowed(true);	44 __ set_constant_pool_allowed(true);

45	45

46 __ LoadObject(R5, ic_data);	46 __ LoadObject(R5, ic_data);

47 __ BranchLinkPatchable(*StubCode::OneArgCheckInlineCache_entry());	47 __ BranchLinkPatchable(*StubCode::OneArgCheckInlineCache_entry());

48 __ ret();	48 __ ret();

49 }	49 }

50	50

51

52 ASSEMBLER_TEST_RUN(IcDataAccess, test) {	51 ASSEMBLER_TEST_RUN(IcDataAccess, test) {

53 uword end = test->payload_start() + test->code().Size();	52 uword end = test->payload_start() + test->code().Size();

54 uword return_address = end - Instr::kInstrSize;	53 uword return_address = end - Instr::kInstrSize;

55 ICData& ic_data = ICData::Handle();	54 ICData& ic_data = ICData::Handle();

56 CodePatcher::GetInstanceCallAt(return_address, test->code(), &ic_data);	55 CodePatcher::GetInstanceCallAt(return_address, test->code(), &ic_data);

57 EXPECT_STREQ("targetFunction",	56 EXPECT_STREQ("targetFunction",

58 String::Handle(ic_data.target_name()).ToCString());	57 String::Handle(ic_data.target_name()).ToCString());

59 EXPECT_EQ(1, ic_data.NumArgsTested());	58 EXPECT_EQ(1, ic_data.NumArgsTested());

60 EXPECT_EQ(0, ic_data.NumberOfChecks());	59 EXPECT_EQ(0, ic_data.NumberOfChecks());

61 }	60 }

62	61

63 } // namespace dart	62 } // namespace dart

64	63

65 #endif // defined TARGET_ARCH_ARM64	64 #endif // defined TARGET_ARCH_ARM64

OLD	NEW