Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 297423002: Improve the UseCounters for HTMLInputElement.webkitdirectory and .incremental (Closed)

Created:
6 years, 7 months ago by philipj_slow
Modified:
6 years, 7 months ago
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org, arv+blink, Inactive, watchdog-blink-watchlist_google.com
Visibility:
Public.

Description

Improve the UseCounters for HTMLInputElement.webkitdirectory and .incremental These are already counted in HTMLInputElement::parseAttribute(), but that code path would not be hit when the IDL attributes are read. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174813

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/core/html/HTMLInputElement.idl View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
philipj_slow
PTAL
6 years, 7 months ago (2014-05-26 13:52:06 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 7 months ago (2014-05-26 14:22:30 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 7 months ago (2014-05-26 14:32:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/297423002/1
6 years, 7 months ago (2014-05-26 14:32:24 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-26 15:14:35 UTC) #5
Message was sent while issue was closed.
Change committed as 174813

Powered by Google App Engine
This is Rietveld 408576698